Re: [Open-FCoE] [PATCH] MAINTAINERS: Change FCoE maintainer

2016-06-28 Thread Vasu Dev
> diff --git a/MAINTAINERS b/MAINTAINERS > index e1b090f..70af8c0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4661,7 +4661,7 @@ S: Maintained >  F: drivers/staging/fbtft/ >   >  FCOE SUBSYSTEM (libfc, libfcoe, fcoe) > -M: Vasu Dev <vasu@int

Re: [PATCHv2] libfc: Update rport reference counting

2016-05-24 Thread Vasu Dev
rt_recv_els_req(struct > fc_lport *lport, struct fc_frame *fp) >   } >   >   mutex_unlock(>rp_mutex); > + kref_put(>kref, rdata->local_port->tt.rport_destroy); >   return; >   >  reject: > @@ -1907,7 +1909,6 @@ static void fc_rport_recv_logo_req(struct > fc_lport *lport, struct fc_frame *fp) >   >   sid = fc_frame_sid(fp); >   > - mutex_lock(>disc.disc_mutex); >   rdata = lport->tt.rport_lookup(lport, sid); >   if (rdata) { >   mutex_lock(>rp_mutex); > @@ -1916,10 +1917,10 @@ static void fc_rport_recv_logo_req(struct > fc_lport *lport, struct fc_frame *fp) >   >   fc_rport_enter_delete(rdata, RPORT_EV_LOGO); >   mutex_unlock(>rp_mutex); > + kref_put(>kref, rdata->local_port- > >tt.rport_destroy); >   } else >   FC_RPORT_ID_DBG(lport, sid, >   "Received LOGO from non-logged-in > port\n"); > - mutex_unlock(>disc.disc_mutex); >   fc_frame_free(fp); >  } Looks good. Acked-by: Vasu Dev <vasu@intel.com> >   -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache_destroy"

2015-11-19 Thread Vasu Dev
- if (scsi_pkt_cachep) > - kmem_cache_destroy(scsi_pkt_cachep); > + kmem_cache_destroy(scsi_pkt_cachep); > } > > /** Looks good. Acked-by: Vasu Dev <vasu@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

2015-10-06 Thread Vasu Dev
> schedule(); > - goto retry; > + continue; > } > > spin_unlock_bh(>fcoe_rx_list.lock); Acked-by: Vasu Dev <vasu@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant_htons to htons

2015-09-01 Thread Vasu Dev
+ fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE); > fcoe->fcoe_packet_type.dev = netdev; > dev_add_pack(>fcoe_packet_type); > Acked-by: Vasu Dev <vasu@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] libfc: correct function name in comment

2015-08-05 Thread Vasu Dev
instance * @vport: fc_vport structure from scsi_transport_fc * @privsize: driver private data size to allocate along with the Scsi_Host */ struct fc_lport *libfc_vport_create(struct fc_vport *vport, int privsize) _ Looks good. Acked-by: Vasu Dev vasu@intel.com -- To unsubscribe from

Re: [PATCH 0/3] libfc patches for kernel v4.2

2015-06-29 Thread Vasu Dev
On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: These libfc fixes are for kernel 4.2 and with two patches CCed for stable kernel also, those two could be picked for current 4.1 cycle now but in case too late for current 4.1 then anyway should get picked up by 4.1 stable kernel later

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call fc_fcp_ddp_done

2015-06-25 Thread Vasu Dev
); + fc_fcp_ddp_done(fsp); rc = fc_exch_done_locked(ep); spin_unlock_bh(ep-ex_lock); if (!rc) Looks good. Acked-by: Vasu Dev vasu@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [Open-FCoE] [PATCH] [trivial] scsi:fcoe: Fix typo a ethernet in fcoe_transport.c

2015-06-23 Thread Vasu Dev
.); +MODULE_PARM_DESC(disable, Disables fcoe on an ethernet interface.); /* notification function for packets from net device */ static struct notifier_block libfcoe_notifier = { I don't this patch applied yet, Looks good. Acked-by: Vasu Dev vasu@intel.com -- To unsubscribe from

[PATCH 2/3] libfc: Fix fc_exch_recv_req() error path

2015-06-05 Thread Vasu Dev
Assche bart.vanass...@sandisk.com Cc: Vasu Dev vasu@intel.com Cc: stable sta...@vger.kernel.org -v2 Updated to revised patch posted at: http://lists.open-fcoe.org/pipermail/fcoe-devel/2015-May/012462.html Signed-off-by: Vasu Dev vasu@intel.com --- drivers/scsi/libfc/fc_exch.c |8

[PATCH 1/3] libfc: Fix a typo in a source code comment

2015-06-05 Thread Vasu Dev
From: Bart Van Assche bart.vanass...@sandisk.com Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com Signed-off-by: Vasu Dev vasu@intel.com --- drivers/scsi/libfc/fc_fcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers

[PATCH 3/3] libfc: Fix fc_fcp_cleanup_each_cmd()

2015-06-05 Thread Vasu Dev
() code flow as discussed here at: http://lists.open-fcoe.org/pipermail/fcoe-devel/2015-May/012471.html ] Signed-off-by: Vasu Dev vasu@intel.com --- drivers/scsi/libfc/fc_fcp.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc

[PATCH 0/3] libfc patches for kernel v4.2

2015-06-05 Thread Vasu Dev
These libfc fixes are for kernel 4.2 and with two patches CCed for stable kernel also, those two could be picked for current 4.1 cycle now but in case too late for current 4.1 then anyway should get picked up by 4.1 stable kernel later. These patches were posted by Bart Van Assche at

Re: [Open-FCoE] [PATCH 0/3] libfc patches for kernel v4.2

2015-06-05 Thread Vasu Dev
On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: These libfc fixes are for kernel 4.2 and with two patches CCed for stable kernel also, those two could be picked for current 4.1 cycle now but in case too late for current 4.1 then anyway should get picked up by 4.1 stable kernel later

Re: [PATCH] scsi: match wait_for_completion_timeout return type

2015-03-18 Thread Vasu Dev
) { + if (!ticks_left) { FC_SCSI_DBG(lport, lun reset failed\n); return FAILED; } Looks good. Acked-by: Vasu Dev vasu@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

[PATCH] libfc: abort an exchange in case of underrun error

2015-03-17 Thread Vasu Dev
Currently exchange is not aborted in case underrun, so this patch fixes this by issuing exchange abort along FC_DATA_UNDRUN error since such error-ed exchange must be aborted first before same can be re-used. Tested-By: Jack Morganjack.mor...@intel.com Signed-off-by: Vasu Dev vasu@intel.com

[PATCH] fcoe: extend ethtool to FC port speed mapping

2014-09-25 Thread Vasu Dev
From: Chris Leech cle...@redhat.com add support for 20 Gbit and 40 Gbit links Signed-off-by: Chris Leech cle...@redhat.com Signed-off-by: Vasu Dev vasu@intel.com --- drivers/scsi/fcoe/fcoe_transport.c | 39 ++-- 1 files changed, 33 insertions(+), 6

Re: [PATCH] libfs: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-09-25 Thread Vasu Dev
); + RCU_INIT_POINTER(fc_active_prov[type], NULL); mutex_unlock(fc_prov_mutex); synchronize_rcu(); } Looks like patch is not yet applied. Acked-by: Vasu Dev vasu@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 14:09 -0700, Nicholas A. Bellinger wrote: So if you don't mind I'll go ahead and queue these up for now in target-pending/for-next, given they are pretty straight-forward fixes. If they end up being problematic, they can be dropped before the v3.16 PULL request goes

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 14:02 -0700, Nicholas A. Bellinger wrote: The break aborts the DataIN send loop and invokes ft_queue_status() below in an attempt to send TASK_SET_FULL status. If the ft_queue_status() - lport-tt.seq_send() also fails, then -ENOMEM will be returned to the target and a

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 16:54 -0400, Neil Horman wrote: On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: debugfs caught this: WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0() ODEBUG: free active (active state

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

2014-06-06 Thread Vasu Dev
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Vasu, This series generates SAM_STAT_TASK_SET_FULL status for lport-tt.seq_send() failures in DataIN + response status codepaths, which is done in order to get the initiator to

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-06 Thread Vasu Dev
DataIN if TASK_SET_FULL status has already been set due to a response lport-tt.seq_send() failure, that has asked target-core to requeue a response. Reported-by: Vasu Dev vasu@linux.intel.com Cc: Vasu Dev vasu@linux.intel.com Cc: Jun Wu j...@stormojo.com Signed-off-by: Nicholas Bellinger

Re: [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures

2014-06-06 Thread Vasu Dev
. It also does the same for a fc_frame_alloc() failures, in order to signal the initiator that it should try to reduce it's current queue_depth, to lower the number of outstanding I/Os on the wire. Reported-by: Vasu Dev vasu@linux.intel.com Cc: Vasu Dev vasu@linux.intel.com Cc: Jun

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-02 Thread Vasu Dev
CC: Robert Love robert.w.l...@intel.com CC: Vasu Dev vasu@intel.com --- drivers/scsi/scsi_transport_fc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index 4628fd5..5bd552c 100644 --- a/drivers/scsi

[PATCH 0/5] Series short description

2008-02-25 Thread Vasu Dev
will simplify openFC implementation which will help in converting OpenFC into generic libfc library as suggested by linux-scsi reviewers. -- Signature : Vasu Dev [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

[PATCH 2/5] Removed outer port use from fcs

2008-02-25 Thread Vasu Dev
will be used for frame alloc and removing inner port later. Also moved outer port event list to fcs_state. Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/include/fc_local_port.h|2 + drivers/scsi/ofc/include/fcs_state.h|4 ++ drivers/scsi/ofc/libfc

[PATCH 4/5] Fixed style error reported by checkpatch

2008-02-25 Thread Vasu Dev
Fixed checkpatch ERROR here: do not use assignment in if condition (+ } else if ((fp = fc_frame_alloc(lp-dev, sizeof(*pl))) == NULL) Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/libfc/fc_sess.c | 57 +- 1 files changed, 31 insertions

[PATCH] Fixed build failure when using -j option of make.

2008-02-25 Thread Vasu Dev
This patch removed make dependency on any other .o files which were causing build failure when make -j 10 used. So moved other .o related code under openfc dir as these .o files were used only by openfc module. Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/Makefile

[PATCH] Removed sa_timer functions as part of libsa cleanup

2008-01-23 Thread Vasu Dev
Instead used standard Linux timer functions directly Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/include/sa_timer.h | 96 --- drivers/scsi/ofc/libfc/fc_disc_targ.c | 20 +++--- drivers/scsi/ofc/libfc/fc_exch.c| 19

[PATCH 0/2] Series short description

2007-12-21 Thread Vasu Dev
The following series implements... Cleaned up FCoE logging by use of simpler logging macro OFC_DBG. -- Signature - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] Removed unused sa_log functions

2007-12-21 Thread Vasu Dev
Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/libsa/Makefile|1 drivers/scsi/ofc/libsa/sa_cons_linux.c | 37 -- drivers/scsi/ofc/libsa/sa_log.c| 117 3 files changed, 0 insertions(+), 155 deletions(-) diff --git