Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

Hi Bjorn, On 4/18/2018 4:41 AM, Bjorn Andersson wrote: On Mon 09 Apr 23:31 PDT 2018, Vivek Gautam wrote: On 4/10/2018 1:39 AM, Bjorn Andersson wrote: On Mon 09 Apr 10:38 PDT 2018, Vivek Gautam wrote: On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

On 4/10/2018 1:39 AM, Bjorn Andersson wrote: On Mon 09 Apr 10:38 PDT 2018, Vivek Gautam wrote: On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: [..] diff --git a/include/linux/phy/phy-qcom-ufs.h b/include/linux/phy/phy-qcom-ufs.h index

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

Hi Bjorn, On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: While we try to transition from a separate ufs phy driver to a more integrated qmp phy driver, don't let SCSI_UFS_QCOM to enable PHY_QCOM_UFS config by default. The users should enable

[PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

- a) ufs_qcom_phy_set_tx_lane_enable() b) void ufs_qcom_phy_save_controller_version() to enable clean build for SCSI_UFS_QCOM. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- drivers/scsi/ufs/Kconfig | 1 - include/linux/phy/phy-qcom-ufs.h | 15 ++- 2 files changed, 14 insertions(+), 2 del

Re: [PATCH v1] scsi: ufs: add 2 lane support

Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash

Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

Hi Asutosh, On 1/30/2018 10:11 AM, Asutosh Das wrote: From: Subhash Jadavani UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for

[PATCH v2 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- C

[PATCH v2 1/5] dt-bindings: phy: Add PHY_TYPE_UFS definition

Add definition for UFS phy type. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v1: - none. include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6c9019

[PATCH v2 3/5] phy: qcom-ufs: Add support to set phy mode

Adding support to set desired UFS phy mode that can be set from the host controller. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v1: - none. drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.

[PATCH v2 5/5] ufs/phy: qcom: Refactor to use phy_init call

Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v1: - The UFS phy retain state in low power mode. The phy can

[PATCH v2 2/5] phy: Add UFS PHY modes

UFS phy has two modes for each High speed generation. These modes are identified by two rates of operations - Rate A, and Rate B. Add these UFS phy modes to phy framework. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v1: - Rebased on linux-phy/next. i

[PATCH v2 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

find it good. [1] https://lkml.org/lkml/2017/8/10/958 Vivek Gautam (5): dt-bindings: phy: Add PHY_TYPE_UFS definition phy: Add UFS PHY modes phy: qcom-ufs: Add support to set phy mode scsi/ufs: qcom: Set phy mode based on the controllers HS MODE ufs/phy: qcom: Refactor to use phy_init

Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

On 09/27/2017 04:14 AM, Subhash Jadavani wrote: On 2017-08-03 23:48, Vivek Gautam wrote: Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam <vivek.

Re: [PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

Hi Subhash, On Wed, Sep 27, 2017 at 4:43 AM, Subhash Jadavani <subha...@codeaurora.org> wrote: > Hi Vivek, > > Please find one comment inline below, rest look good. > > Regards, > Subhash > > > On 2017-08-03 23:48, Vivek Gautam wrote: >> >> Ref

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

On Fri, Aug 11, 2017 at 5:33 AM, Martin K. Petersen wrote: > > Vivek, > >> Can you kindly review this patch series (for UFS controller changes) >> and consider giving your Ack so that Kishon can pull in the series >> through phy tree. > > SCSI piece looks OK. Thank

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

Hi Martin, Subhash On Wed, Aug 9, 2017 at 11:18 AM, Kishon Vijay Abraham I <kis...@ti.com> wrote: > Vivek, > > On Tuesday 08 August 2017 09:20 PM, Vivek Gautam wrote: >> Hi Koshon, >> >> On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: >>> Hi, >&g

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

Hi Koshon, On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: Hi, On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: Refactoring the qcom-ufs phy and host controller code to move further towards the generic phy usage. Right now the qcom-ufs exports a bunch of APIs that are used

[PATCH 1/5] dt-bindings: phy: Add PHY_TYPE_UFS definition

Add definition for UFS phy type. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6c901930eb3e..d16e8755f6a9 100644 --- a/incl

[PATCH 2/5] phy: Add UFS PHY modes

UFS phy has two modes for each High speed generation. These modes are identified by two rates of operations - Rate A, and Rate B. Add these UFS phy modes to phy framework. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- include/linux/phy/phy.h | 2 ++ 1 file changed, 2 inse

[PATCH 3/5] phy: qcom-ufs: Add support to set phy mode

Adding support to set desired UFS phy mode that can be set from the host controller. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.c | 14 ++ drivers/phy/qualcomm/ph

[PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 3 +++ 1 file changed, 3 inse

[PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 -- drivers/phy/qualcomm/phy-qc

[PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

phy. Host controller can direct the phy to set the respective configurations based on the phy modes. The patch-series has been tested with necessary dt patches on db820c. Vivek Gautam (5): dt-bindings: phy: Add PHY_TYPE_UFS definition phy: Add UFS PHY modes phy: qcom-ufs: Add support to set

Re: [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

On Wed, Nov 9, 2016 at 4:36 AM, Martin K. Petersen <martin.peter...@oracle.com> wrote: >>>>>> "Vivek" == Vivek Gautam <vivek.gau...@codeaurora.org> writes: > > Vivek> Here's the rebased version of patches based on 4.10/scsi-queue > Vivek&g

[PATCH v5 08/12] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH v5 10/12] phy: qcom-ufs: Remove common layer phy exit callback

at a later point. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs-i.h| 1 - drivers/phy/phy-qcom-ufs-qmp-14nm.c | 7 ++- drivers/phy/phy-qcom-ufs-qmp-20nm.c | 7 ++- drivers/

[PATCH v5 07/12] phy: qcom-ufs: Remove unnecessary function declarations

Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c | 131 + 1 file changed, 6

[PATCH v5 12/12] scsi/ufs: qcom: Don't free resource-managed kmalloc element

Host is allocated by managed kmalloc (devm_kmalloc). The memory allocated with this function is automatically freed on driver detach. So, no need to make an exclusive free call over it. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH v5 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.

[PATCH v5 11/12] scsi/ufs: qcom: Add phy_exit call in hcd exit path

Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH v5 03/12] phy: qcom-ufs: Cleanup clock and regulator initialization

Different menthods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-

[PATCH v5 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy

Add a new compatible string for 14nm ufs phy present on msm8996 chipset. This phy is bit different from the legacy 14nm ufs phy in terms of the clocks that are needed to be handled in the driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH v5 02/12] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c | 5 + 1

[PATCH v5 05/12] phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy

The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy present on msm8996. So skip obtaining these clocks using compatible match. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c

[PATCH v5 01/12] phy: qcom-ufs: Remove unnecessary BUG_ON

BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c |

[PATCH v5 06/12] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs-qmp-14nm.c | 16 drivers/phy/phy-qcom-ufs-qmp-20nm.c | 16 drivers/phy/phy-qcom-ufs.c | 9 --

[PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

://git.linaro.org/landing-teams/working/qualcomm/kernel.git [2] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam (12): phy: qcom-ufs: Remove unnecessary BUG_ON phy: qcom-ufs: Use devm sibling of kstrdup for regulator names phy: qcom-ufs: Cleanup clock and regulator initialization

[PATCH v4 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v3: - Moved phy_power_off() under *link not active* check during aggr

Re: [PATCH v3 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy

Hi, On Tue, Nov 1, 2016 at 2:41 AM, Subhash Jadavani <subha...@codeaurora.org> wrote: > On 2016-10-29 13:22, Vivek Gautam wrote: >> >> Add a new compatible string for 14nm ufs phy present on msm8996 >> chipset. This phy is bit different from the legacy 14nm ufs ph

Re: [PATCH v3 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

Hi Subhash, On Wed, Nov 2, 2016 at 12:17 AM, Subhash Jadavani <subha...@codeaurora.org> wrote: > On 2016-10-29 13:22, Vivek Gautam wrote: >> >> Add phy clock enable code to phy_power_on/off callbacks, and >> remove explicit calls to enable these phy clocks from

[PATCH v3 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy

Add a new compatible string for 14nm ufs phy present on msm8996 chipset. This phy is bit different from the legacy 14nm ufs phy in terms of the clocks that are needed to be handled in the driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch in v3 of this cleanup

[PATCH v3 02/12] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v1. drivers/phy/phy-qc

[PATCH v3 12/12] scsi/ufs: qcom: Don't free resource-managed kmalloc element

Host is allocated by managed kmalloc (devm_kmalloc). The memory allocated with this function is automatically freed on driver detach. So, no need to make an exclusive free call over it. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch added in v3 of this cleanup

[PATCH v3 10/12] phy: qcom-ufs: Remove common layer phy exit callback

at a later point. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v2. drivers/phy/phy-qcom-ufs-i.h| 1 - drivers/phy/phy-qcom-ufs-qmp-14nm.c | 7 ++- drivers/phy/phy-qcom-ufs-qmp

[PATCH v3 03/12] phy: qcom-ufs: Cleanup clock and regulator initialization

Different menthods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v1.

[PATCH v3 11/12] scsi/ufs: qcom: Add phy_exit call in hcd exit path

Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v2. drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed,

[PATCH v3 06/12] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- Changes since v2: - Addressed review comment about commmit message: s/phy_exit/phy_power_off drivers/phy/phy-qcom-ufs-qmp-14nm.c | 16 drivers/phy/phy-

[PATCH v3 08/12] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH v3 07/12] phy: qcom-ufs: Remove unnecessary function declarations

Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v2. drivers/phy/phy-qcom-ufs.c | 133 +

[PATCH v3 05/12] phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy

The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy present on msm8996. So skip obtaining these clocks using compatible match. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch in v3 of this cleanup series. Comes in place of the following patch in v2 - phy

[PATCH v3 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v2: - Added phy_power_on() and phy_power_off() calls to power-cycle t

[PATCH v3 01/12] phy: qcom-ufs: Remove unnecessary BUG_ON

BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No changes since v1. drivers/

[PATCH v3 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

handling Vivek Gautam (12): phy: qcom-ufs: Remove unnecessary BUG_ON phy: qcom-ufs: Use devm sibling of kstrdup for regulator names phy: qcom-ufs: Cleanup clock and regulator initialization phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy phy: qcom-ufs: Skip obtaining rx

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

Hi, On Wed, Oct 19, 2016 at 10:50 PM, Vivek Gautam <vivek.gau...@codeaurora.org> wrote: > Hi, > > > On Wed, Oct 19, 2016 at 2:48 AM, Stephen Boyd <sb...@codeaurora.org> wrote: >> On 10/18/2016 07:28 AM, Vivek Gautam wrote: >>> From: Yaniv Gardi <yga...@c

Re: [PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

Hi, On Thu, Oct 27, 2016 at 1:50 AM, Kishon Vijay Abraham I <kis...@ti.com> wrote: > > > On Tuesday 18 October 2016 07:58 PM, Vivek Gautam wrote: >> remove() callback does a phy_exit() only and nothing else now. > > remove callback calls a phy_power_off(

Re: [PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

Hi Martin, On Tue, Oct 25, 2016 at 6:10 AM, Martin K. Petersen <martin.peter...@oracle.com> wrote: >>>>>> "Vivek" == Vivek Gautam <vivek.gau...@codeaurora.org> writes: > > Vivek, > > Vivek> These patches cleanup the ufs phy driver to an e

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

On Thu, Oct 20, 2016 at 12:48 AM, Subhash Jadavani <subha...@codeaurora.org> wrote: > On 2016-10-19 10:45, Vivek Gautam wrote: >> >> Hi, >> >> >> On Wed, Oct 19, 2016 at 1:43 AM, Subhash Jadavani >> <subha...@codeaurora.org> wro

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

Hi, On Wed, Oct 19, 2016 at 1:43 AM, Subhash Jadavani <subha...@codeaurora.org> wrote: > On 2016-10-18 07:28, Vivek Gautam wrote: >> >> Add phy clock enable code to phy_power_on/off callbacks, and >> remove explicit calls to enable these phy clocks from the >>

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

Hi, On Wed, Oct 19, 2016 at 2:48 AM, Stephen Boyd <sb...@codeaurora.org> wrote: > On 10/18/2016 07:28 AM, Vivek Gautam wrote: >> From: Yaniv Gardi <yga...@codeaurora.org> >> >> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk >> are n

[PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

remove() callback does a phy_exit() only and nothing else now. The phy_exit() over the generic phy is called from the phy consumer, and phy provider driver should not explicitly need to call any phy_exit(). So discard the remove callback for qcom-ufs phy platform drivers. Signed-off-by: Vivek

[PATCH v2 05/10] phy: qcom-ufs: Cleanup clock and regulator initialization

Different menthods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No change since v1.

[PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- Changes since v1: - staticized ufs_qcom_phy_enable(/disable)_ref_clk(), - stat

[PATCH v2 06/10] phy: qcom-ufs: Remove unnecessary function declarations

Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch added in v2 series. drivers/phy/phy-qcom-ufs.c | 133 + 1 file changed, 63 insertions(+), 70 del

[PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

From: Yaniv Gardi <yga...@codeaurora.org> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk are no longer exist, we should not fail when their initialization fail, but rather just report with debug message. Signed-off-by: Yaniv Gardi <yga...@codeaurora.org> Signed-off-by:

[PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit path

Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch added in v2 series. drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/d

[PATCH v2 02/10] phy: qcom-ufs: Remove unnecessary BUG_ON

BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No change since v1. drivers/

[PATCH v2 03/10] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- No change since v1. drivers/phy/phy-qc

[PATCH v2 07/10] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH v2 10/10] phy: qcom-ufs: Remove common layer phy exit callback

at a later point. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> --- New patch added in v2 series. drivers/phy/phy-qcom-ufs-i.h| 1 - drivers/phy/phy-qcom-ufs-qmp-14nm.c | 7 ++- drivers/phy/phy-qcom-ufs-qmp-20nm.c | 7 ++- drivers/phy/phy-qcom-ufs.c

[PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

ufs_qcom_phy_exit() from 'phy-qcom-ufs' driver, since this api just powers off the phy. [1] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git [2] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam (9): phy: qcom-ufs: Remove unnecessary BUG_ON phy: qcom-ufs: Use devm

[PATCH 7/7] ufs-qcom: phy/hcd: Refactoring phy clock handling

Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom

[PATCH 3/7] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c | 5 + 1

[PATCH 1/7] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

From: Yaniv Gardi <yga...@codeaurora.org> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk are no longer exist, we should not fail when their initialization fail, but rather just report with debug message. Signed-off-by: Yaniv Gardi <yga...@codeaurora.org> Signed-off-by:

[PATCH 5/7] phy: qcom-ufs: Cleanup clock and regulator initialization

Different methods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-

[PATCH 6/7] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani

[PATCH 2/7] phy: qcom-ufs: Remove unnecessary BUG_ON

BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/phy/phy-qcom-ufs.c |

[PATCH 4/7] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

remove() callback does a phy_exit() only and nothing else now. The phy_exit() over the generic phy is called from the phy consumer, and phy provider driver should not explicitly need to call any phy_exit(). So discard the remove callback for qcom-ufs phy platform drivers. Signed-off-by: Vivek

[PATCH 0/7] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

, and have been tested with on db820c hardware with integration branch - 'integration-linux-qcomlt' of qualcomm linaro lt tree [1]. [1] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git Vivek Gautam (6): phy: qcom-ufs: Remove unnecessary BUG_ON phy: qcom-ufs: Use devm sibling