[2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2007-07-29 Thread Adrian Bunk
Every file should #include the headers containing the prototypes for its global functions (in this case for scsi_schedule_eh()). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28 17:10:48.0 +0200 +++

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2006-11-29 Thread Matthew Wilcox
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote: +#include scsi_transport_api.h scsi_transport_api.h is a weird little file. It's not included by anything in the drivers/scsi directory, only drivers/scsi/libsas/sas_scsi_host.c:#include ../scsi_transport_api.h

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2006-11-29 Thread James Smart
Matthew Wilcox wrote: On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote: +#include scsi_transport_api.h scsi_transport_api.h is a weird little file. It's not included by anything in the drivers/scsi directory, only drivers/scsi/libsas/sas_scsi_host.c:#include

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2006-11-29 Thread Matthew Wilcox
On Wed, Nov 29, 2006 at 09:13:35AM -0500, James Smart wrote: would it only go in include/scsi if it intends to be an exported api for LLDD's and/or user apps ? and stay in drivers/scsi if its an internal api within the scsi subsystem itself ? It isn't clear to me that's the intended use of