Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

On Thu, Dec 10, 2015 at 8:15 PM, Martin K. Petersen wrote: >> "Rasmus" == Rasmus Villemoes writes: > > Rasmus> If char is signed and one of these bytes happen to have a value > Rasmus> outside the ascii range, the corresponding output

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

> "Andy" == Andy Shevchenko writes: Andy> I have several patches on SCSI subsytem like this one. Some of Andy> them didn't manage kernel (even having Ack!) for years already. Andy> Is it okay if I collect them together and send a bunch once again Re-sending to

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

On Thu, 2015-12-10 at 14:13 -0500, Martin K. Petersen wrote: > > > > > > "Andy" == Andy Shevchenko writes: > > Andy> I have several patches on SCSI subsytem like this one. Some of > Andy> them didn't manage kernel (even having Ack!) for years already. > Andy> Is it

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

> "Rasmus" == Rasmus Villemoes writes: Rasmus> If char is signed and one of these bytes happen to have a value Rasmus> outside the ascii range, the corresponding output will consist Rasmus> of "ff" followed by the two hex chars that were actually Rasmus>

[PATCH] [SCSI] osd: fix signed char versus %02x issue

If char is signed and one of these bytes happen to have a value outside the ascii range, the corresponding output will consist of "ff" followed by the two hex chars that were actually intended. One way to fix it would be to change the casts to (u8*) aka (unsigned char*), but it is much simpler

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

On 12/08/2015 04:25 PM, Rasmus Villemoes wrote: > If char is signed and one of these bytes happen to have a value > outside the ascii range, the corresponding output will consist of > "ff" followed by the two hex chars that were actually > intended. One way to fix it would be to change the