Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-25 Thread Tom Yan
What if a UAS bridge requires specific SCSI command (e.g. UNMAP) to be issued unqueued/untagged? Would track_queue_depth help? On 25 May 2016 at 19:04, Hans de Goede wrote: > Hi, > > > On 24-05-16 14:44, James Bottomley wrote: >> >> On Tue, 2016-05-24 at 08:53 +0200, Hans de

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-25 Thread Hans de Goede
Hi, On 24-05-16 14:44, James Bottomley wrote: On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote: Hi, On 23-05-16 19:36, James Bottomley wrote: On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-24 Thread James Bottomley
On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote: > Hi, > > On 23-05-16 19:36, James Bottomley wrote: > > On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: > > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host > > > level") > > > removed the scsi_change_queue_depth()

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-24 Thread Hans de Goede
Hi, On 23-05-16 19:36, James Bottomley wrote: On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-23 Thread Tom Yan
On 24 May 2016 at 01:36, James Bottomley wrote: > > Are you sure about this? For spinning rust, experiments imply that the > optimal queue depth per device is somewhere between 2 and 4. Obviously > that's not true for SSDs, so it depends on your use case.

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-23 Thread James Bottomley
On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") > removed the scsi_change_queue_depth() call from uas_slave_configure() > assuming that the slave would inherit the host's queue_depth, which > that commit sets to the

[PATCH] USB: uas: Fix slave queue_depth not being set

2016-05-23 Thread Hans de Goede
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's queue_depth, which that commit sets to the same value. This is incorrect, without the