Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
On Sat, Aug 27 2005, Douglas Gilbert wrote: Jeff Garzik wrote: Does the attached look OK to everybody? Jeff, Yes. And after an exchange with Jens, it would probably be safer to map transfer_length=0 for READ_10 and READ_16 (as well as WRITE_10 and WRITE_16) to a nop on the ATA

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jeff Garzik
Here is the patch I just checked in. Jeff diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c --- a/drivers/scsi/libata-scsi.c +++ b/drivers/scsi/libata-scsi.c @@ -630,11 +630,19 @@ static unsigned int ata_scsi_rw_xlat(str tf-lbah = scsicmd[3];

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
On Sat, Aug 27 2005, Jeff Garzik wrote: Here is the patch I just checked in. Looks perfect. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Jeff Garzik
Douglas Gilbert wrote: Jeff Garzik wrote: @@ -1093,28 +1189,54 @@ unsigned int buflen) { u8 *scsicmd = args-cmd-cmnd, *p, *last; -unsigned int page_control, six_byte, output_len; +const u8 sat_blk_desc[] = {0, 0, 0, 0, 0, 0, 0x2, 0x0}; +/* 512 byte blocks,

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Douglas Gilbert
Jeff Garzik wrote: Does the attached look OK to everybody? Jeff, Yes. And after an exchange with Jens, it would probably be safer to map transfer_length=0 for READ_10 and READ_16 (as well as WRITE_10 and WRITE_16) to a nop on the ATA side. Otherwise an ATA disk may attempt to transfer 2**16

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Jens Axboe
On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* + * For READ_6 and WRITE_6 (only) + *

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Douglas Gilbert
Jeff Garzik wrote: Douglas Gilbert wrote: This is a revised patch following this post: http://marc.theaimsgroup.com/?l=linux-scsim=112461881419898w=2 The plan is to add MODE SELECT SCSI command support to libata so that parameters such as WCE and DRA can be changed by a user (i.e.

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Douglas Gilbert
Jens Axboe wrote: On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* + * For READ_6 and WRITE_6 (only) +

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Jens Axboe
On Tue, Aug 23 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* +

[PATCH] libata: error processing + rw 6 byte fix

2005-08-22 Thread Douglas Gilbert
This is a revised patch following this post: http://marc.theaimsgroup.com/?l=linux-scsim=112461881419898w=2 The plan is to add MODE SELECT SCSI command support to libata so that parameters such as WCE and DRA can be changed by a user (i.e. Write(back) Cache Enable and Disable Read Ahead