Re: [PATCH] libata: write cache and read ahead

2005-08-24 Thread Christoph Hellwig
On Tue, Aug 23, 2005 at 07:22:59PM -0400, Luben Tuikov wrote: On 08/22/05 01:12, Douglas Gilbert wrote: I was surprised how much code needed changing. With MODE SELECT's issues with libata addressed various other SAT extras should be much easier to implement. That should make libata more

Re: [PATCH] libata: write cache and read ahead

2005-08-24 Thread Luben Tuikov
On 08/24/05 07:03, Douglas Gilbert wrote: Luben Tuikov wrote: On 08/22/05 01:12, Douglas Gilbert wrote: I was surprised how much code needed changing. With MODE SELECT's issues with libata addressed various other SAT extras should be much easier to implement. That should make libata more

Re: [PATCH] libata: write cache and read ahead

2005-08-23 Thread Luben Tuikov
On 08/22/05 01:12, Douglas Gilbert wrote: I was surprised how much code needed changing. With MODE SELECT's issues with libata addressed various other SAT extras should be much easier to implement. That should make libata more attractive as a SAT layer for SAS LLDDs (that don't do it already

Re: [PATCH] libata: write cache and read ahead

2005-08-22 Thread Jeff Garzik
Douglas Gilbert wrote: With repect to my libata TEST UNIT READY patch there is a good chance that can be dropped. The feedback from the t10 reflector seems to indicate the current definition may be changed, unfortunately the proposed changes may require some SAT state information being held for

Re: [PATCH] libata: write cache and read ahead

2005-08-22 Thread Douglas Gilbert
NOTIFYJeff Garzik wrote: Douglas Gilbert wrote: The attachment is for discussion. It adds MODE SELECT support to libata allowing the write(back) cache and read ahead to be manipulated by users [i.e. the WCE and DRA ** bits in the SCSI Caching mode page]. In general I approve of this

[PATCH] libata: write cache and read ahead

2005-08-21 Thread Douglas Gilbert
The attachment is for discussion. It adds MODE SELECT support to libata allowing the write(back) cache and read ahead to be manipulated by users [i.e. the WCE and DRA ** bits in the SCSI Caching mode page]. The patch is against lk 2.6.13-rc6 and includes the SSU patch (but not the TUR patch).