Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-27 Thread Martin K. Petersen
Bart, > Avoid that building with W=1 causes the kernel-doc tool to complain > about function arguments that have not been documented in the libsas > kernel-doc headers. Avoid that the short description starts with a > hyphen by changing "--" into "-" in the first line of the kernel-doc >

Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-23 Thread John Garry
On 22/02/2018 21:49, Bart Van Assche wrote: Avoid that building with W=1 causes the kernel-doc tool to complain about function arguments that have not been documented in the libsas kernel-doc headers. Avoid that the short description starts with a hyphen by changing "--" into "-" in the first

[PATCH] libsas: Fix kernel-doc headers

2018-02-22 Thread Bart Van Assche
Avoid that building with W=1 causes the kernel-doc tool to complain about function arguments that have not been documented in the libsas kernel-doc headers. Avoid that the short description starts with a hyphen by changing "--" into "-" in the first line of the kernel-doc headers. Signed-off-by:

Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-22 Thread Bart Van Assche
On Wed, 2018-02-14 at 16:29 +, John Garry wrote: > On 13/02/2018 17:49, Bart Van Assche wrote: > > On 02/13/18 02:17, John Garry wrote: > > > On 12/02/2018 18:45, Bart Van Assche wrote: > > > > -/** > > > > +/* > > > > * sas_configure_parent -- configure routing table of parent > > > > - *

Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-14 Thread John Garry
On 13/02/2018 17:49, Bart Van Assche wrote: On 02/13/18 02:17, John Garry wrote: On 12/02/2018 18:45, Bart Van Assche wrote: [ ... ] -/** +/* * sas_init_disc -- initialize the discovery struct in the port * @port: pointer to struct port I wonder why you get no complaint that @disc

Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-13 Thread Bart Van Assche
On 02/13/18 02:17, John Garry wrote: On 12/02/2018 18:45, Bart Van Assche wrote: [ ... ] -/** +/*   * sas_init_disc -- initialize the discovery struct in the port   * @port: pointer to struct port I wonder why you get no complaint that @disc argument is not mentioned, Hello John, Since I

Re: [PATCH] libsas: Fix kernel-doc headers

2018-02-13 Thread John Garry
On 12/02/2018 18:45, Bart Van Assche wrote: Avoid that building with W=1 causes the kernel-doc tool to complain about the libsas kernel-doc headers. Hi Bart, A few comments, below: Signed-off-by: Bart Van Assche --- drivers/scsi/libsas/sas_discover.c | 6 +++---

[PATCH] libsas: Fix kernel-doc headers

2018-02-12 Thread Bart Van Assche
Avoid that building with W=1 causes the kernel-doc tool to complain about the libsas kernel-doc headers. Signed-off-by: Bart Van Assche --- drivers/scsi/libsas/sas_discover.c | 6 +++--- drivers/scsi/libsas/sas_expander.c | 20 ++--