Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-02 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> Commit 669f044170d8 ("scsi: srp_transport: Move queuecommand() Bart> wait code to SCSI core") can make scsi_internal_device_block() Bart> sleep. However, the mpt3sas driver can call this function from an Bart> interrupt

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-01 Thread Omar Sandoval
On Wed, Mar 01, 2017 at 05:09:48PM +, Bart Van Assche wrote: > On Wed, 2017-03-01 at 09:04 -0800, Omar Sandoval wrote: > > Thanks, Bart, you can add > > > > Tested-by: Omar Sandoval > > Hello Omar, > > Have you been able to test both code paths - scsi-mq enabled and scsi-mq

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-01 Thread Bart Van Assche
On Wed, 2017-03-01 at 09:28 -0800, Omar Sandoval wrote: > Just tried on blk-mq and I didn't get the splat, seems to be fine. Thanks for the testing! Bart.

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-01 Thread Omar Sandoval
On Wed, Mar 01, 2017 at 09:00:36AM -0800, Bart Van Assche wrote: > Commit 669f044170d8 ("scsi: srp_transport: Move queuecommand() wait > code to SCSI core") can make scsi_internal_device_block() sleep. > However, the mpt3sas driver can call this function from an interrupt > handler. Hence add a

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-01 Thread Bart Van Assche
On Wed, 2017-03-01 at 09:04 -0800, Omar Sandoval wrote: > Thanks, Bart, you can add > > Tested-by: Omar Sandoval Hello Omar, Have you been able to test both code paths - scsi-mq enabled and scsi-mq disabled? Thanks, Bart.

[PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-01 Thread Bart Van Assche
Commit 669f044170d8 ("scsi: srp_transport: Move queuecommand() wait code to SCSI core") can make scsi_internal_device_block() sleep. However, the mpt3sas driver can call this function from an interrupt handler. Hence add a second argument to scsi_internal_device_block() that restores the old