Re: [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()

2018-01-30 Thread Martin K. Petersen
Dan, > My static checker complains about an out of bounds read: > > drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo() > error: buffer overflow 'hd->sel_timeout' 255 <= u32max. > > It's true that we probably should have a bounds check here. Applied to 4.16/scsi-fixes, thanks!

Re: [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()

2018-01-29 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

[PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()

2018-01-25 Thread Dan Carpenter
My static checker complains about an out of bounds read: drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo() error: buffer overflow 'hd->sel_timeout' 255 <= u32max. It's true that we probably should have a bounds check here. Signed-off-by: Dan Carpenter