Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-27 Thread Quinn Tran
Christoph, Currently, the command state within TCM (se_cmd.t_state) only track command states from the point of new to the Back End and from Back End up to QLA driver. From the debug perspective, that¹s only half the picture. The other half comes from qla2xxx¹s private command state provided by

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-25 Thread Christoph Hellwig
Which debug printk do you care about? I'd much prefer having a trace point inside the driver which could even pretty print it instead of the hack where a driver defined binary value is printed by the core. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-23 Thread Christoph Hellwig
On Tue, Jul 21, 2015 at 03:07:55PM -0700, Spencer Baugh wrote: From: Dilip Kumar Uppugandla di...@purestorage.com Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. I think the

[PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Spencer Baugh
From: Dilip Kumar Uppugandla di...@purestorage.com Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. Signed-off-by: Dilip Kumar Uppugandla di...@purestorage.com Signed-off-by: Spencer Baugh

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Himanshu Madhani
On 7/21/15, 3:07 PM, Spencer Baugh sba...@catern.com wrote: From: Dilip Kumar Uppugandla di...@purestorage.com Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. Signed-off-by: Dilip Kumar