Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-12 Thread Sagi Grimberg
This looks correct to me, Reviewed-by: Christoph Hellwig h...@lst.de But: this will truncate 32bit sector numbers. Maybe we need to enable descriptor format sense data for large enough LUs. That should be easy enough now that the sense data is constructed using scsi helpers. Let me

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-11 Thread Christoph Hellwig
On Wed, Jul 08, 2015 at 06:00:03PM +0300, Sagi Grimberg wrote: In fixed size sense format the information field is a four byte field. This looks correct to me, Reviewed-by: Christoph Hellwig h...@lst.de But: this will truncate 32bit sector numbers. Maybe we need to enable descriptor format

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-09 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi In fixed size sense format the information field is a four byte Sagi field. Correct. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the