Re: [PATCH] scsi: handle special return codes for ABORTED COMMAND

2018-01-29 Thread Martin Wilck
On Mon, 2018-01-29 at 23:39 +, Bart Van Assche wrote: > On Tue, 2018-01-30 at 00:30 +0100, Martin Wilck wrote: > > + static struct aborted_cmd_blist blist[] = { > > Please consider to declare this array const. That doesn't work because I want to store the "warned" flag in it. And I think

Re: [PATCH] scsi: handle special return codes for ABORTED COMMAND

2018-01-29 Thread Bart Van Assche
On Tue, 2018-01-30 at 00:30 +0100, Martin Wilck wrote: > + static struct aborted_cmd_blist blist[] = { Please consider to declare this array const. > + for (i = 0; i < sizeof(blist)/sizeof(struct aborted_cmd_blist); i++) { Have you considered to use ARRAY_SIZE()? Thanks, Bart.

[PATCH] scsi: handle special return codes for ABORTED COMMAND

2018-01-29 Thread Martin Wilck
(Resending, because I forgot to cc linux-scsi. BIG SORRY!) Introduce a new blist flag that indicates the device may return certain sense code/ASC/ASCQ combinations that indicate different treatment than normal. In particular, some devices need unconditional retry (aka ADD_TO_MLQUEUE) under