Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-07 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> I think I should have included this in the tested-by tag Mauricio> email, for documentation/evidence: no regression observed in Mauricio> system shutdown path. Applied to 4.11/scsi-fixes. --

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-07 Thread Mauricio Faria de Oliveira
Martin, On 03/07/2017 02:24 AM, Benjamin Herrenschmidt wrote: On Mon, 2017-03-06 at 22:46 -0500, Martin K. Petersen wrote: I don't recall a consensus being reached on this patch. What would be the opposition ? Without it kexec breaks. With it, it works ... That is the argument I'd

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-06 Thread Benjamin Herrenschmidt
On Mon, 2017-03-06 at 22:46 -0500, Martin K. Petersen wrote: > > > > > > "Mauricio" == Mauricio Faria de Oliveira > > > > > et.ibm.com> writes: > > Mauricio> On 02/12/2017 07:49 PM, Anton Blanchard wrote: > > > We see lpfc devices regularly fail during kexec. Fix this by > >

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-06 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> On 02/12/2017 07:49 PM, Anton Blanchard wrote: >> We see lpfc devices regularly fail during kexec. Fix this by adding a >> shutdown method which mirrors the remove method. Mauricio> @mkp, @jejb:

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-06 Thread Mauricio Faria de Oliveira
On 02/12/2017 07:49 PM, Anton Blanchard wrote: We see lpfc devices regularly fail during kexec. Fix this by adding a shutdown method which mirrors the remove method. Reviewed-by: Mauricio Faria de Oliveira Tested-by: Mauricio Faria de Oliveira

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-14 Thread Eric W. Biederman
Brian King writes: > On 02/13/2017 08:04 PM, Benjamin Herrenschmidt wrote: >> On Mon, 2017-02-13 at 15:57 -0600, Brian King wrote: >>> If we do transition to use remove rather than shutdown, I think we >>> want >>> some way for a device driver to know whether we are

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-14 Thread Brian King
On 02/13/2017 08:04 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-02-13 at 15:57 -0600, Brian King wrote: >> If we do transition to use remove rather than shutdown, I think we >> want >> some way for a device driver to know whether we are doing kexec or >> not. >> A RAID adapter with a write

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-13 Thread Benjamin Herrenschmidt
On Tue, 2017-02-14 at 15:45 +1300, Eric W. Biederman wrote: > The only difference ever that should exist between shutdown and remove > is do you clean up kernel data structures.  The shutdown method is > allowed to skip the cleanup up kernel data structures that the remove > method needs to make.

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-13 Thread Benjamin Herrenschmidt
On Mon, 2017-02-13 at 15:57 -0600, Brian King wrote: > If we do transition to use remove rather than shutdown, I think we > want > some way for a device driver to know whether we are doing kexec or > not. > A RAID adapter with a write cache is going to want to flush its write > cache on a PCI

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-13 Thread Eric W. Biederman
Brian King writes: > On 02/12/2017 07:01 PM, Benjamin Herrenschmidt wrote: >> On Mon, 2017-02-13 at 13:21 +1300, Eric W. Biederman wrote: Good point, at the very least we should call remove if shutdown doesn't exist. Eric: could we make the changes Ben

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-13 Thread Brian King
On 02/12/2017 07:01 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-02-13 at 13:21 +1300, Eric W. Biederman wrote: >>> Good point, at the very least we should call remove if shutdown doesn't >>> exist. Eric: could we make the changes Ben suggests? >> >> Definitely. That was the original design

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Benjamin Herrenschmidt
On Mon, 2017-02-13 at 13:21 +1300, Eric W. Biederman wrote: > > Good point, at the very least we should call remove if shutdown doesn't > > exist. Eric: could we make the changes Ben suggests? > > Definitely.  That was the original design of the kexec interface > but people were worried about

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Eric W. Biederman
Anton Blanchard writes: > Hi Ben, > > On Mon, 13 Feb 2017 10:14:54 +1100 > Benjamin Herrenschmidt wrote: > >> On Mon, 2017-02-13 at 08:49 +1100, Anton Blanchard wrote: >> > From: Anton Blanchard >> > >> > We see lpfc devices

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Anton Blanchard
Hi Ben, On Mon, 13 Feb 2017 10:14:54 +1100 Benjamin Herrenschmidt wrote: > On Mon, 2017-02-13 at 08:49 +1100, Anton Blanchard wrote: > > From: Anton Blanchard > > > > We see lpfc devices regularly fail during kexec. Fix this by adding > > a shutdown

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Benjamin Herrenschmidt
On Mon, 2017-02-13 at 08:49 +1100, Anton Blanchard wrote: > From: Anton Blanchard > > We see lpfc devices regularly fail during kexec. Fix this by adding > a shutdown method which mirrors the remove method. Or instead finally do what I've been advocating for years (and even

[PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Anton Blanchard
From: Anton Blanchard We see lpfc devices regularly fail during kexec. Fix this by adding a shutdown method which mirrors the remove method. Signed-off-by: Anton Blanchard --- drivers/scsi/lpfc/lpfc_init.c | 1 + 1 file changed, 1 insertion(+) diff --git