RE: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Kashyap Desai
@avagotech.com; linux- s...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster There is currently no %po format extension, so currently the letters on are simply skipped and the pointer is printed as expected (while missing the word

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Joe Perches
On Tue, 2015-02-10 at 22:16 +0530, Kashyap Desai wrote: Acked-by: Kashyap Desai kashyap.de...@avagotech.com -Original Message- From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] Sent: Friday, February 06, 2015 8:04 PM [] There is currently no %po format extension, so

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Joe Perches
Convert printks to pr_level Miscellaneous: o Coalesce formats Add and remove spaces where appropriate when coalescing o Add pr_fmt o Remove embedded prefixes o Convert embedded function names to %s:, __func__ o Realign arguments o Outdent one block that was inappropriately indented o Use

[PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-06 Thread Rasmus Villemoes
There is currently no %po format extension, so currently the letters on are simply skipped and the pointer is printed as expected (while missing the word on). However, it is probably only a matter of time before someone comes up with a %po extension, at which point this is likely to fail