Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-08 Thread Martin K. Petersen
Colin, > The 2nd check to see if request_size is less than zero is redundant > because the first check takes error exit path on this condition. So, > since it is redundant, remove it. Applied to 4.12/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-04 Thread Tyrel Datwyler
On 05/03/2017 09:29 AM, Colin King wrote: > From: Colin Ian King > > The 2nd check to see if request_size is less than zero is redundant > because the first check takes error exit path on this condition. So, > since it is redundant, remove it. > > Detected by

[PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

2017-05-03 Thread Colin King
From: Colin Ian King The 2nd check to see if request_size is less than zero is redundant because the first check takes error exit path on this condition. So, since it is redundant, remove it. Detected by CoverityScan, CID#146149 ("Logically Dead Code") Signed-off-by: