Re: [PATCH] scsi: qedf: Cleanup the type of io_log->op

2017-05-08 Thread Martin K. Petersen
Dan, > We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so > this should also be unsigned char. The other thing is that this is > displayed in the debugfs: Applied to 4.12/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedf: Cleanup the type of io_log->op

2017-05-04 Thread Chad Dupuis
On Wed, 3 May 2017, 5:23pm, Dan Carpenter wrote: > We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so > this should also be unsigned char. The other thing is that this is > displayed in the debugfs: > > seq_printf(s, "0x%02x:", io_log->op); > > Smatch complains that the

[PATCH] scsi: qedf: Cleanup the type of io_log->op

2017-05-03 Thread Dan Carpenter
We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so this should also be unsigned char. The other thing is that this is displayed in the debugfs: seq_printf(s, "0x%02x:", io_log->op); Smatch complains that the formatting won't work for negative values so changing it to