Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-04 Thread Sreekanth Reddy
On Tue, Apr 3, 2018 at 9:26 PM, Bart Van Assche wrote: > On Tue, 2018-04-03 at 10:11 +0530, Sreekanth Reddy wrote: >> [SR] No, driver calls _scsih_flush_running_cmds during Host reset time >> and during host reset time driver will set 'ioc->shost_recovery' flag. >> So in the scsih_qcmd() driver wi

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-03 Thread Bart Van Assche
On Tue, 2018-04-03 at 10:11 +0530, Sreekanth Reddy wrote: > [SR] No, driver calls _scsih_flush_running_cmds during Host reset time > and during host reset time driver will set 'ioc->shost_recovery' flag. > So in the scsih_qcmd() driver will return the incoming SCSI cmds with > "SCSI_MLQUEUE_HOST_BU

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-02 Thread Sreekanth Reddy
On Mon, Apr 2, 2018 at 8:55 PM, Bart Van Assche wrote: > On Mon, 2018-04-02 at 11:53 +0530, Sreekanth Reddy wrote: >> On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig >> wrote: >> > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: >> > > Check scsi tracker for NULL before accessing

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-02 Thread Bart Van Assche
On Mon, 2018-04-02 at 11:53 +0530, Sreekanth Reddy wrote: > On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig wrote: > > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: > > > Check scsi tracker for NULL before accessing it. > > > And in some places there are possibilities for getting

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-01 Thread Sreekanth Reddy
On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig wrote: > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: >> Check scsi tracker for NULL before accessing it. >> And in some places there are possibilities for getting valid st >> but still other fields are not set. > > Please explain

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-03-30 Thread Bart Van Assche
On Fri, 2018-03-30 at 15:07 +0530, Chaitra P B wrote: > diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c > b/drivers/scsi/mpt3sas/mpt3sas_ctl.c > index c1b17d6..2f27d5c 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c > @@ -590,7 +590,8 @@ _ctl_set_task_m

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-03-30 Thread Christoph Hellwig
On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: > Check scsi tracker for NULL before accessing it. > And in some places there are possibilities for getting valid st > but still other fields are not set. Please explain how that could ever happen. You should never see a scsi_cmnd witho

[PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-03-30 Thread Chaitra P B
Check scsi tracker for NULL before accessing it. And in some places there are possibilities for getting valid st but still other fields are not set. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 5 - drivers/scsi/mpt3sas/mpt3sas_scsih.