Re: [PATCH 1/1] scsi: Add EH Start Unit retry

2007-04-02 Thread Brian King
James Bottomley wrote: On Thu, 2007-03-29 at 15:25 -0500, Brian King wrote: This is pretty much an open coded for loop ... how about just doing a for loop as attached below? Fine by me. I was simply coding it up to look like scsi_eh_tur. Thanks, Brian The two advantages to this are:

Re: [PATCH 1/1] scsi: Add EH Start Unit retry

2007-04-02 Thread James Bottomley
On Mon, 2007-04-02 at 13:57 -0500, Brian King wrote: I agree. The reason the ipr adapter firmware added this UA in this configuration was to support SCSI 1 reservations and communicate to the host that any reservation previously held to the disk array is now lost since the adapter was reset.

Re: [PATCH 1/1] scsi: Add EH Start Unit retry

2007-04-01 Thread James Bottomley
On Thu, 2007-03-29 at 15:25 -0500, Brian King wrote: - int rtn; + int retry_cnt = 1, rtn; +retry_stu: rtn = scsi_send_eh_cmnd(scmd, stu_command, 6, START_UNIT_TIMEOUT, 0); - if (rtn == SUCCESS) + +

[PATCH 1/1] scsi: Add EH Start Unit retry

2007-03-29 Thread Brian King
Currently, the scsi error handler will issue a START_UNIT command if the drive indicates it needs its motor started and the allow_restart flag is set in the scsi_device. If, after the scsi error handler invokes a host adapter reset due to error recovery, a device is in a unit attention state AND

Re: [PATCH 1/1] scsi: Add EH Start Unit retry

2007-03-29 Thread Douglas Gilbert
Brian King wrote: Currently, the scsi error handler will issue a START_UNIT command if the drive indicates it needs its motor started and the allow_restart flag is set in the scsi_device. If, after the scsi error handler invokes a host adapter reset due to error recovery, a device is in a