Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

2017-01-09 Thread Martin K. Petersen
> "Nicolas" == Nicolas Iooss writes: Nicolas> qla24xx_enable_msix() calls scnprintf() with a non-literal Nicolas> format string. This makes clang report -Wformat-security Nicolas> warnings when compiling this function: Applied 1+2 to 4.11/scsi-queue. -- Martin

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

2017-01-06 Thread Madhani, Himanshu
On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >qla24xx_enable_msix() calls scnprintf() with a non-literal format >string. This makes clang report -Wformat-security warnings when >compiling this function: > >drivers/scsi/qla2xxx/qla_isr.c:3083:7: error: format

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

2017-01-05 Thread Martin K. Petersen
> "Nicolas" == Nicolas Iooss writes: Nicolas> qla24xx_enable_msix() calls scnprintf() with a non-literal Nicolas> format string. This makes clang report -Wformat-security Nicolas> warnings when compiling this function: Himanshu: Please review these two patches!

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

2017-01-02 Thread Bart Van Assche
On Mon, 2016-12-26 at 14:23 +0100, Nicolas Iooss wrote: > Even though msix_entries[...].name are initialized as literal strings > with no % character and are never modified, introduce a "%s" format > parameter in order to silent this -Wformat-security warning and make > clang able to detect at

[PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

2016-12-26 Thread Nicolas Iooss
qla24xx_enable_msix() calls scnprintf() with a non-literal format string. This makes clang report -Wformat-security warnings when compiling this function: drivers/scsi/qla2xxx/qla_isr.c:3083:7: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]