Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-26 Thread Tomas Henzl
Hi James, I've gotten mail that you have accepted patches 2/3 and 3/3 from this series. This one has been accepted by Steve also, so please consider taking also this 1/3. Thanks, Tomas On 08/01/2013 03:11 PM, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The cmd_pool_bits is

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-07 Thread Tomas Henzl
On 08/06/2013 05:46 PM, scame...@beardog.cce.hp.com wrote: On Fri, Aug 02, 2013 at 01:13:59PM +0200, Tomas Henzl wrote: On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-06 Thread scameron
On Fri, Aug 02, 2013 at 01:13:59PM +0200, Tomas Henzl wrote: On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: [...] Btw. on line 1284 - isn't it similar to

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-02 Thread Tomas Henzl
On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: [...] Btw. on line 1284 - isn't it similar to patch 2/3 ? ^^^ Oh, missed this the first time around, the sop

[PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can be removed too. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 15 ++- 1 file changed, 6

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread scameron
On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can be removed too. Signed-off-by: Tomas Henzl the...@redhat.com

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can be

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread scameron
On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The cmd_pool_bits is protected everywhere with a spinlock, we don't

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote: From: Tomas Henzl the...@redhat.com The

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread scameron
On Thu, Aug 01, 2013 at 04:59:45PM +0200, Tomas Henzl wrote: On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread Tomas Henzl
On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:59:45PM +0200, Tomas Henzl wrote: On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote: On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote: On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-01 Thread scameron
On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: [...] Btw. on line 1284 - isn't it similar to patch 2/3 ? ^^^ Oh, missed this the first time around, the sop driver uses the make_request_fn() interface, and it's not a