Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

2018-09-17 Thread Madhani, Himanshu
Hi Bart, > On Sep 15, 2018, at 9:50 PM, Bart Van Assche wrote: > > External Email > > On 09/14/18 14:28, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c >> b/drivers/scsi/qla2xxx/qla_nvmet.c >> new file mode 100644 >> [ ... ] >> +#if

Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

2018-09-15 Thread Bart Van Assche
On 09/14/18 14:28, Himanshu Madhani wrote: diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c b/drivers/scsi/qla2xxx/qla_nvmet.c new file mode 100644 [ ... ] +#ifIS_ENABLED(CONFIG_NVME_TARGET_FC) [ ... ] +#endif This style of using #if / #endif is not acceptable. Instead,

[PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch adds initial files to enable NVMe Target Support Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvmet.c | 780 +++