Re: [PATCH 10/10] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

Hi Bart, In this case online check is move to far, the vha is still not dereferenced. The right patch is moving online flag just after getting vha. diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 9520b1f..11f84dc 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++

[PATCH 10/10] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

Avoid that the fcport structure gets leaked if bsg_job-request-msgcode == FC_BSG_HST_ELS_NOLOGIN, the fcport allocation succeeds and the !vha-flags.online branch is taken. This was detected by Coverity. However, Coverity does not recognize that all qla2x00_process_els() callers specify either