Re: [PATCH 12/15] target: add callout to test a session

2018-07-18 Thread Mike Christie
On 07/18/2018 05:46 PM, Bart Van Assche wrote: > On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote: >> + int (*test_session)(struct se_session *, u8 timeout); > > Does any of the patches in this series define a test_session callback > function? Patch 14 does. > > What is the unit of

Re: [PATCH 12/15] target: add callout to test a session

2018-07-18 Thread Bart Van Assche
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote: > + int (*test_session)(struct se_session *, u8 timeout); Does any of the patches in this series define a test_session callback function? What is the unit of the timeout parameter? 1/HZ, ms or s? Thanks, Bart.

[PATCH 12/15] target: add callout to test a session

2018-07-15 Thread Mike Christie
This adds a callout and configfs file so userspace apps can test a session. It is useful for apps that do not want to enable target nops that may disrupt normal traffic and only want to test it during specific events like failover/failbacks when there might be multiple sessions to the same target