Re: [PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

2017-04-26 Thread Tomohiro Kusumi
Hi, Thanks for your review. > yes, this makes it more readable, but i am not sure why we will have to type > cast UFSHCD_STATUS_READY macro to u32 type? i think it is redundant, let me > know if you think otherwise. Sorry, nothing really. I'll resend without u32 cast in short (i.e. change to

Re: [PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

2017-04-26 Thread Subhash Jadavani
On 2017-04-20 05:01, kusumi.tomoh...@gmail.com wrote: From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +--

[PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious

2017-04-20 Thread kusumi . tomohiro
From: Tomohiro Kusumi It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 11 +-- drivers/scsi/ufs/ufshci.h | 4 2 files changed, 5 insertions(+), 10