Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-22 Thread Vladislav Bolkhovitin
Henrique de Moraes Holschuh wrote: On Thu, 22 Mar 2007, Vladislav Bolkhovitin wrote: Seems, there is another way of doing a bank spin up / spin down: doing it in two passes. On the first pass START_STOP will be issued with IMMED=1 on all devices, then on the second pass START_STOP will be iss

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-22 Thread Henrique de Moraes Holschuh
On Thu, 22 Mar 2007, Vladislav Bolkhovitin wrote: > Seems, there is another way of doing a bank spin up / spin down: doing > it in two passes. On the first pass START_STOP will be issued with > IMMED=1 on all devices, then on the second pass START_STOP will be > issued with IMMED=0. So the devic

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-22 Thread Vladislav Bolkhovitin
Tejun Heo wrote: Hello, Douglas. Douglas Gilbert wrote: Tejun, I note at this point that the IMMED bit in the START STOP UNIT cdb is clear. [The code might note that as well.] All SCSI disks that I have seen, implement the IMMED bit and according to the SAT standard, so should SAT layers like

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
James Bottomley wrote: > On Wed, 2007-03-21 at 02:08 +0900, Tejun Heo wrote: >> I got too comfortable with libata-dev#upstream and forgot to verify >> patches against scsi-misc-2.6. Sorry about that. If you don't have >> objection against the content, I'll resubmit the SCSI part against >> scsi-m

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
Hello, Douglas. Douglas Gilbert wrote: > Tejun, > I note at this point that the IMMED bit in the > START STOP UNIT cdb is clear. [The code might > note that as well.] All SCSI disks that I have > seen, implement the IMMED bit and according to > the SAT standard, so should SAT layers like the > one

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Tue, 2007-03-20 at 13:58 -0400, Douglas Gilbert wrote: > I note at this point that the IMMED bit in the > START STOP UNIT cdb is clear. [The code might > note that as well.] All SCSI disks that I have > seen, implement the IMMED bit and according to > the SAT standard, so should SAT layers like

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Douglas Gilbert
Tejun Heo wrote: > Implement SBC START/STOP management. sdev->mange_start_stop is added. > When it's set to one, sd STOPs the device on suspend and shutdown and > STARTs it on resume. sdev->manage_start_stop defaults is in sdev > instead of scsi_disk cdev to allow ->slave_config() override the >

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Wed, 2007-03-21 at 02:08 +0900, Tejun Heo wrote: > I got too comfortable with libata-dev#upstream and forgot to verify > patches against scsi-misc-2.6. Sorry about that. If you don't have > objection against the content, I'll resubmit the SCSI part against > scsi-misc-2.6. Once it's in scsi-m

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
James Bottomley wrote: > On Wed, 2007-03-21 at 00:13 +0900, Tejun Heo wrote: >> Implement SBC START/STOP management. sdev->mange_start_stop is added. >> When it's set to one, sd STOPs the device on suspend and shutdown and >> STARTs it on resume. sdev->manage_start_stop defaults is in sdev >> ins

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Wed, 2007-03-21 at 00:13 +0900, Tejun Heo wrote: > Implement SBC START/STOP management. sdev->mange_start_stop is added. > When it's set to one, sd STOPs the device on suspend and shutdown and > STARTs it on resume. sdev->manage_start_stop defaults is in sdev > instead of scsi_disk cdev to all

[PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
Implement SBC START/STOP management. sdev->mange_start_stop is added. When it's set to one, sd STOPs the device on suspend and shutdown and STARTs it on resume. sdev->manage_start_stop defaults is in sdev instead of scsi_disk cdev to allow ->slave_config() override the default configuration but i