RE: [PATCH 2/4] scsi: pm8001: fix update_flash

2014-07-10 Thread Suresh Thiagarajan
On Mon, Jul 7, 2014 at 8:49 PM, Tomas Henzl the...@redhat.com wrote: The driver checks the return valu, but after he tries to wait_for_completion which might never happen. Also the ioctlbuffer is freed at the end of the function, so the first removal is not needed. Looks good. Thanks Tomas.

[PATCH 2/4] scsi: pm8001: fix update_flash

2014-07-07 Thread Tomas Henzl
The driver checks the return valu, but after he tries to wait_for_completion which might never happen. Also the ioctlbuffer is freed at the end of the function, so the first removal is not needed. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_ctl.c | 6 +++--- 1