Re: [PATCH 3/3] Make blk_cleanup_queue() wait until request_fn finished

2012-10-02 Thread Bart Van Assche
On 10/01/12 19:41, Dan Williams wrote: On Thu, Sep 27, 2012 at 9:39 AM, Bart Van Assche bvanass...@acm.org wrote: [ ... ] diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 593fc71..03571a3 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1517,10

Re: [PATCH 3/3] Make blk_cleanup_queue() wait until request_fn finished

2012-10-01 Thread Dan Williams
On Thu, Sep 27, 2012 at 9:39 AM, Bart Van Assche bvanass...@acm.org wrote: Some request_fn implementations, e.g. scsi_request_fn(), unlock the queue lock. Make sure that blk_cleanup_queue() waits until all active request_fn invocations have finished. This fixes a potential use-after-free at

[PATCH 3/3] Make blk_cleanup_queue() wait until request_fn finished

2012-09-27 Thread Bart Van Assche
Some request_fn implementations, e.g. scsi_request_fn(), unlock the queue lock. Make sure that blk_cleanup_queue() waits until all active request_fn invocations have finished. This fixes a potential use-after-free at the end of scsi_request_fn(). Reported-by: Chanho Min chanho@lge.com Cc: