RE: [PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-07-02 Thread Suresh Thiagarajan
On Fri, Jun 27, 2014 at 3:51 PM, Tomas Henzl the...@redhat.com wrote: On 06/27/2014 08:09 AM, Viswas G wrote: HI Tomas, This lock is not needed as we are already protecting the tag allocation and freeing with the pm8001_ha-lock. We are always acquiring this lock before calling

RE: [PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-06-27 Thread Viswas G
HI Tomas, This lock is not needed as we are already protecting the tag allocation and freeing with the pm8001_ha-lock. We are always acquiring this lock before calling pm8001_tag_alloc(). We are allocating and freeing the tag in following paths, 1) Request/Response path : This we are

Re: [PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-06-27 Thread Tomas Henzl
On 06/27/2014 08:09 AM, Viswas G wrote: HI Tomas, This lock is not needed as we are already protecting the tag allocation and freeing with the pm8001_ha-lock. We are always acquiring this lock before calling pm8001_tag_alloc(). We are allocating and freeing the tag in following paths,

[PATCH 3/4] pm8001: add a new spinlock to protect the CCB

2014-06-26 Thread Tomas Henzl
Patch adds a new spinlock to protect the ccb management. It may happen that concurrent threads become the same tag value from the 'alloc' function', the spinlock prevents this situation. Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/pm8001/pm8001_init.c | 1 +