[PATCH 3/4] scsi: improved eh timeout handler

2013-10-30 Thread Hannes Reinecke
When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the error handler. This patch implements a new scsi_abort_command()

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-09 Thread Baruch Even
On Thu, Jun 6, 2013 at 12:43 PM, Hannes Reinecke h...@suse.de wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-09 Thread Hannes Reinecke
On 06/10/2013 02:12 AM, Baruch Even wrote: On Thu, Jun 6, 2013 at 12:43 PM, Hannes Reinecke h...@suse.de wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-07 Thread Ren Mingxin
Hi, Hannes: On 06/07/2013 04:28 AM, Jörn Engel wrote: On Thu, 6 June 2013 22:39:14 +0200, Hannes Reinecke wrote: + spin_unlock_irqrestore(sdev-list_lock, flags); + SCSI_LOG_ERROR_RECOVERY(3, + scmd_printk(KERN_INFO, scmd, +

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-07 Thread Hannes Reinecke
On 06/07/2013 08:25 AM, Ren Mingxin wrote: Hi, Hannes: On 06/07/2013 04:28 AM, Jörn Engel wrote: On Thu, 6 June 2013 22:39:14 +0200, Hannes Reinecke wrote: +spin_unlock_irqrestore(sdev-list_lock, flags); +SCSI_LOG_ERROR_RECOVERY(3, +scmd_printk(KERN_INFO, scmd,

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-07 Thread Jörn Engel
On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: + spin_lock_irqsave(sdev-list_lock, flags); + list_for_each_entry_safe(scmd, tmp, sdev-eh_abort_list, eh_entry) { + list_del_init(scmd-eh_entry); + spin_unlock_irqrestore(sdev-list_lock, flags); I

[PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the error handler. This patch implements a new scsi_abort_command()

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 06:23 PM, Jörn Engel wrote: On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 22:39:14 +0200, Hannes Reinecke wrote: + spin_unlock_irqrestore(sdev-list_lock, flags); + SCSI_LOG_ERROR_RECOVERY(3, + scmd_printk(KERN_INFO, scmd, + aborting command %p\n, scmd)); + rtn =