Re: [PATCH 3/5] scsi: make eh_eflags persistent

2016-06-22 Thread Christoph Hellwig
On Mon, Jun 20, 2016 at 11:35:38AM +0200, Hannes Reinecke wrote: > To detect if a failed command has been retried we must not > clear scmd->eh_eflags when EH finishes. > The flag should be persistent throughout the lifetime > of the command. Please explain what issue this solves - the behavior

[PATCH 3/5] scsi: make eh_eflags persistent

2016-06-20 Thread Hannes Reinecke
To detect if a failed command has been retried we must not clear scmd->eh_eflags when EH finishes. The flag should be persistent throughout the lifetime of the command. Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 3 --- drivers/scsi/scsi_error.c | 4

Re: [PATCH 3/5] scsi: make eh_eflags persistent

2015-12-03 Thread Johannes Thumshirn
On Thu, 2015-12-03 at 08:17 +0100, Hannes Reinecke wrote: > To detect if a failed command has been retried we must not > clear scmd->eh_eflags when EH finishes. > The flag should be persistent throughout the lifetime > of the command. > > Signed-off-by: Hannes Reinecke > --- >  

Re: [PATCH 3/5] scsi: make eh_eflags persistent

2015-12-03 Thread Christoph Hellwig
On Thu, Dec 03, 2015 at 08:17:41AM +0100, Hannes Reinecke wrote: > To detect if a failed command has been retried we must not > clear scmd->eh_eflags when EH finishes. > The flag should be persistent throughout the lifetime > of the command. So we save away eh_eflags before potentially reusing

[PATCH 3/5] scsi: make eh_eflags persistent

2015-12-02 Thread Hannes Reinecke
To detect if a failed command has been retried we must not clear scmd->eh_eflags when EH finishes. The flag should be persistent throughout the lifetime of the command. Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 3 --- drivers/scsi/scsi_error.c | 4