Otherwise it counter intuitively returns 0 if device is present.

Signed-off-by: Venkatraman S <svenk...@ti.com>
Reviewed-by: Namjae Jeon <linkinj...@gmail.com>
Acked-by: Santosh Y <santos...@gmail.com>
Cc: James Bottomley <james.bottom...@hansenpartnership.com>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
---
 drivers/scsi/ufs/ufshcd.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 40c43bf..48b01fe 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -232,11 +232,11 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba 
*hba)
  *                           the host controller
  * @reg_hcs - host controller status register value
  *
- * Returns 0 if device present, non-zero if no device detected
+ * Returns 1 if device present, 0 if no device detected
  */
 static inline int ufshcd_is_device_present(u32 reg_hcs)
 {
-       return (DEVICE_PRESENT & reg_hcs) ? 0 : -1;
+       return (DEVICE_PRESENT & reg_hcs) ? 1 : 0;
 }
 
 /**
@@ -911,7 +911,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba)
 
        /* check if device present */
        reg = readl((hba->mmio_base + REG_CONTROLLER_STATUS));
-       if (ufshcd_is_device_present(reg)) {
+       if (!ufshcd_is_device_present(reg)) {
                dev_err(&hba->pdev->dev, "cc: Device not present\n");
                err = -ENXIO;
                goto out;
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to