Re: [PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-25 Thread James Bottomley
There are quite a few commented out debugging statements and deprecated C++ style comments dotted throughout this driver ... could these be corrected? (move to C style comments and either implement a debugging strategy or pull out the statements). Another thing that strikes me is on the ARM side,

RE: [PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-25 Thread Tucker, Greg B
James, thank you for the corrections. I think I can fix all of these as suggested and resubmit a new patch shortly. Another thing that strikes me is on the ARM side, it looks like this is effectively vectoring up to a user space target ... is that true? And if so, would the existing in-kernel

[PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-24 Thread Dan Williams
From: Greg Tucker [EMAIL PROTECTED] Enable Linux to access the other core as if it were a scsi target. Signed-off-by: Greg Tucker [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/imu/Kconfig |7 drivers/scsi/Makefile |1