Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-07-12 Thread Sreekanth Reddy
On Tue, Jul 10, 2018 at 10:58 PM, Sreekanth Reddy wrote: > On Mon, Jul 9, 2018 at 5:14 PM, Sreekanth Reddy > wrote: >> On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy >> wrote: >>> On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche >>> wrote: On 06/24/18 23:10, Sreekanth Reddy wrote:

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-07-10 Thread Sreekanth Reddy
On Mon, Jul 9, 2018 at 5:14 PM, Sreekanth Reddy wrote: > On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy > wrote: >> On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche >> wrote: >>> On 06/24/18 23:10, Sreekanth Reddy wrote: Before calling scsi_internal_device_block_nowait() API;

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-07-09 Thread Sreekanth Reddy
On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy wrote: > On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche > wrote: >> On 06/24/18 23:10, Sreekanth Reddy wrote: >>> >>> Before calling scsi_internal_device_block_nowait() API; driver sets >>> sas_device_priv_data->block flag as one. And in the

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-27 Thread Sreekanth Reddy
On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche wrote: > On 06/24/18 23:10, Sreekanth Reddy wrote: >> >> Before calling scsi_internal_device_block_nowait() API; driver sets >> sas_device_priv_data->block flag as one. And in the scsih_qcmd() >> driver checks for this flag as shown below and

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-27 Thread Bart Van Assche
On 06/24/18 23:10, Sreekanth Reddy wrote: Before calling scsi_internal_device_block_nowait() API; driver sets sas_device_priv_data->block flag as one. And in the scsih_qcmd() driver checks for this flag as shown below and return the commands with host busy status. } else if

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-25 Thread Sreekanth Reddy
On Sat, Jun 23, 2018 at 2:56 AM, Bart Van Assche wrote: > On 06/22/18 09:38, Sreekanth Reddy wrote: >> >> In driver's .resume() callback function, driver is doing IOC reset >> operation. And as per your suggestion we tried using >> scsi_internal_device_block_nowait() to block the all the devices

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-22 Thread Bart Van Assche
On 06/22/18 09:38, Sreekanth Reddy wrote: In driver's .resume() callback function, driver is doing IOC reset operation. And as per your suggestion we tried using scsi_internal_device_block_nowait() to block the all the devices attached to the HBA before going for IOC reset operation. During

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-22 Thread Sreekanth Reddy
On Fri, Jun 22, 2018 at 8:22 PM, Bart Van Assche wrote: > On 06/21/18 22:35, Sreekanth Reddy wrote: >> >> No, lock_system_sleep() is not inserted in the interrupt context. we >> have inserted it in .resume() call back function just before issuing >> the IOC reset. > > > That's the wrong place to

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-22 Thread Bart Van Assche
On 06/21/18 22:35, Sreekanth Reddy wrote: No, lock_system_sleep() is not inserted in the interrupt context. we have inserted it in .resume() call back function just before issuing the IOC reset. That's the wrong place to insert a lock_system_sleep() call. Please have a look at

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-21 Thread Sreekanth Reddy
On Thu, Jun 21, 2018 at 7:49 PM, Bart Van Assche wrote: > On Thu, 2018-06-21 at 15:41 +0530, Sreekanth Reddy wrote: >> Bart, we tried using lock_system_sleep() before calling IOC reset >> operation in .resume() callback function and unlock_system_sleep() >> after the IOC reset. With this code

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-21 Thread Bart Van Assche
On Thu, 2018-06-21 at 15:41 +0530, Sreekanth Reddy wrote: > Bart, we tried using lock_system_sleep() before calling IOC reset > operation in .resume() callback function and unlock_system_sleep() > after the IOC reset. With this code change we see system is going to > hang state during hibernation

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-21 Thread Sreekanth Reddy
On Wed, Jun 20, 2018 at 11:43 PM, Bart Van Assche wrote: > On Wed, 2018-06-20 at 09:18 +0530, Chaitra Basappa wrote: >> We have tried with calling scsi_internal_device_block_nowait() API before >> doing IOC reset (i.e. host reset) and called >> scsi_internal_device_unblock_nowait() after

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-20 Thread Bart Van Assche
On Wed, 2018-06-20 at 09:18 +0530, Chaitra Basappa wrote: > We have tried with calling scsi_internal_device_block_nowait() API before > doing IOC reset (i.e. host reset) and called > scsi_internal_device_unblock_nowait() after performing IOC reset. > We have tested this code change with various

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-14 Thread Bart Van Assche
On Thu, 2018-06-14 at 06:25 -0400, Chaitra P B wrote: > As a part of host reset operation, driver will flushout all IOs > outstanding at driver level with "DID_RESET" result. > To find which are all commands outstanding at the driver level, > driver loops with smid starting from one to HBA queue

[PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-14 Thread Chaitra P B
Below kernel BUG was observed while running IOs with host reset (issued from application), mpt3sas_cm0: diag reset: SUCCESS [ cut here ] WARNING: CPU: 12 PID: 4336 at drivers/scsi/mpt3sas/mpt3sas_base.c:3282 mpt3sas_base_clear_st+0x3d/0x40 [mpt3sas] Modules linked in: