Re: [PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-03 Thread Sagi Grimberg
On 3/3/2014 6:41 AM, Mike Christie wrote: On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 4046241..a58a6bb 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -395,6 +395,10 @@ static int

Re: [PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-02 Thread Mike Christie
On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 4046241..a58a6bb 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -395,6 +395,10 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)

[PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-02-27 Thread Sagi Grimberg
iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike transport errors, DIF errors should not prevent successful completion of the