Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-13 Thread Darrick J. Wong
Patrick Mansfield wrote: > On Mon, Dec 04, 2006 at 03:32:20PM -0800, Darrick J. Wong wrote: >> The Quantum GoVault SATAPI removable disk device returns ATA_ERR in >> response to a REPORT LUNS packet. If this happens to an ATAPI device >> that is attached to a SAS controller (this is the case with

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-13 Thread Patrick Mansfield
On Mon, Dec 04, 2006 at 03:32:20PM -0800, Darrick J. Wong wrote: > The Quantum GoVault SATAPI removable disk device returns ATA_ERR in > response to a REPORT LUNS packet. If this happens to an ATAPI device > that is attached to a SAS controller (this is the case with sas_ata), > the device does no

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-13 Thread James Bottomley
On Wed, 2006-12-13 at 09:38 -0800, Darrick J. Wong wrote: > Sorry, I should have clarified this earlier--the Quantum GoVault is a > removable disk drive, not a CD-ROM. The device is reminiscent of Zip > disks, but the cartridge is a sealed unit and contains a 2.5" SATA disk > inside; hence it's no

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-13 Thread Darrick J. Wong
James Bottomley wrote: > Er, if it's really a CD-ROM, doesn't it need a blacklist entry with > BLIST_ROM then? Regardless, MMC is the only standard that seems to be > inconsistent in this regard. Anything claiming to conform to SBC will > need to be explicitly blacklisted if it claims SCSI-3 or

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-13 Thread James Bottomley
On Tue, 2006-12-12 at 14:24 -0800, Darrick J. Wong wrote: > I tried out the patch below, but with it applied, SCSI still issues > REPORT LUNS to the device. It seems that sdev->type = -1 and bflags = 0 Yes, the inquiry scanning is being called too early ... largely so BLIST_ROM can work, I suppos

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-12 Thread Darrick J. Wong
James Bottomley wrote: > I thought we were closing in on agreeing that the SPC/MMC > inconsistencies made this the correct candidate fix. I tried out the patch below, but with it applied, SCSI still issues REPORT LUNS to the device. It seems that sdev->type = -1 and bflags = 0 when scsi_get_devi

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-11 Thread Jeff Garzik
James Bottomley wrote: On Mon, 2006-12-11 at 11:24 -0500, Jeff Garzik wrote: Darrick J. Wong wrote: The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case wi

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-11 Thread James Bottomley
On Mon, 2006-12-11 at 11:24 -0500, Jeff Garzik wrote: > Darrick J. Wong wrote: > > The Quantum GoVault SATAPI removable disk device returns ATA_ERR in > > response to a REPORT LUNS packet. If this happens to an ATAPI device > > that is attached to a SAS controller (this is the case with sas_ata),

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-11 Thread Jeff Garzik
Darrick J. Wong wrote: The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device"

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-07 Thread Douglas Gilbert
James Bottomley wrote: > On Mon, 2006-12-04 at 15:32 -0800, Darrick J. Wong wrote: >> The Quantum GoVault SATAPI removable disk device returns ATA_ERR in >> response to a REPORT LUNS packet. If this happens to an ATAPI device >> that is attached to a SAS controller (this is the case with sas_ata),

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-07 Thread James Bottomley
On Mon, 2006-12-04 at 15:32 -0800, Darrick J. Wong wrote: > The Quantum GoVault SATAPI removable disk device returns ATA_ERR in > response to a REPORT LUNS packet. If this happens to an ATAPI device > that is attached to a SAS controller (this is the case with sas_ata), > the device does not load

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-07 Thread Douglas Gilbert
Jeff Garzik wrote: > Darrick J. Wong wrote: >> The Quantum GoVault SATAPI removable disk device returns ATA_ERR in >> response to a REPORT LUNS packet. If this happens to an ATAPI device >> that is attached to a SAS controller (this is the case with sas_ata), >> the device does not load because SC

Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-07 Thread Jeff Garzik
Darrick J. Wong wrote: The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device"

[PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-04 Thread Darrick J. Wong
The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device" that won't report its LUN