Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-07-01 Thread Martin K. Petersen
Johannes, > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the qpair->qp_lock. Applied to 4.13/scsi-queue.

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-28 Thread Madhani, Himanshu
> On Jun 23, 2017, at 12:10 AM, Johannes Thumshirn wrote: > > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-27 Thread Madhani, Himanshu
Hi Martin, On 6/27/17, 6:32 PM, "Martin K. Petersen" wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-27 Thread Martin K. Petersen
> In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the qpair->qp_lock. Cavium folks, please review! --

[PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-23 Thread Johannes Thumshirn
In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock. Signed-off-by: Johannes Thumshirn