Re: [PATCH v2 1/4] scsi: ufs: Change HCI macro to actual bit position

2017-10-11 Thread Martin K. Petersen
Alim, > Currently UFS HCI uses UFS_BIT() macro to get various bit position for > the hardware registers status bits. Which makes code longer instead of > shorter. This macro does not improve code readability as well. Lets > re-write these macro definition with the actual bit position. Applied

Re: [PATCH v2 1/4] scsi: ufs: Change HCI macro to actual bit position

2017-10-03 Thread Bart Van Assche
On Tue, 2017-10-03 at 20:51 +0530, Alim Akhtar wrote: > Currently UFS HCI uses UFS_BIT() macro to get various bit > position for the hardware registers status bits. Which makes > code longer instead of shorter. This macro does not improve > code readability as well. > Lets re-write these macro

[PATCH v2 1/4] scsi: ufs: Change HCI macro to actual bit position

2017-10-03 Thread Alim Akhtar
Currently UFS HCI uses UFS_BIT() macro to get various bit position for the hardware registers status bits. Which makes code longer instead of shorter. This macro does not improve code readability as well. Lets re-write these macro definition with the actual bit position. Suggested-by: Bart Van