Re: [PATCH v2 4/5] target: split out helper for cxn timeout error stashing

2018-10-13 Thread David Disseldorp
On Fri, 12 Oct 2018 09:11:27 -0700, Bart Van Assche wrote: > There have been too many problems with strcpy() and buffer overflows in the > past. If the source and destination strings both have the same size, please > add a BUILD_BUG_ON() statement that verifies that at compile time. If that >

Re: [PATCH v2 4/5] target: split out helper for cxn timeout error stashing

2018-10-12 Thread Bart Van Assche
On Fri, 2018-10-12 at 12:01 +0200, David Disseldorp wrote: > +void iscsit_fill_cxn_timeout_err_stats(struct iscsi_session *sess) > +{ > + struct iscsi_portal_group *tpg = sess->tpg; > + struct iscsi_tiqn *tiqn = tpg->tpg_tiqn; > + > + if (!tiqn) > + return; > + > +

[PATCH v2 4/5] target: split out helper for cxn timeout error stashing

2018-10-12 Thread David Disseldorp
Replace existing nested code blocks with helper function calls. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_erl0.c | 15 +- drivers/target/iscsi/iscsi_target_util.c | 35 +--- drivers/target/iscsi/iscsi_target_util.h | 1 + 3