Re: [PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-10 Thread Tejun Heo
Hello, On Wed, Mar 05, 2014 at 12:17:30PM -0800, Dan Williams wrote: +#define ata_port_resume_sync(ap, msg) ata_port_resume_common((ap), (msg), false) +#define queue_ata_port_resume(ap, msg) ata_port_resume_common((ap), (msg), true) Let's please use proper static functions. The compiler

Re: [PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-10 Thread Tejun Heo
On Mon, Mar 10, 2014 at 04:29:47PM -0400, Tejun Heo wrote: Let's please use proper static functions. The compiler can deal with inlining. Also, maybe ata_port_resume() and ata_port_resume_async() are better names for the wrappers? So, if the suggested names don't jive well with the rest of

[PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-05 Thread Dan Williams
Tejun says: At least for libata, worrying about suspend/resume failures don't make whole lot of sense. If suspend failed, just proceed with suspend. If the device can't be woken up afterwards, that's that. There isn't anything we could have done differently anyway. The same for