Re: [PATCH v5 3/6] scsi: ufs: Add ufs-bsg module

2018-09-20 Thread Christoph Hellwig
This looks generally fine to me (module comments from Bart).

RE: [PATCH v5 3/6] scsi: ufs: Add ufs-bsg module

2018-09-20 Thread Avri Altman
t; Petersen ; linux-scsi@vger.kernel.org > Cc: Stanislav Nijnikov ; Avi Shchislowski > ; Alex Lemberg ; > Subhash Jadavani ; Vinayak Holikatti > > Subject: Re: [PATCH v5 3/6] scsi: ufs: Add ufs-bsg module > > On 9/17/18 9:08 AM, Avri Altman wrote: > > +*Caveat emptor*: The

Re: [PATCH v5 3/6] scsi: ufs: Add ufs-bsg module

2018-09-18 Thread Bart Van Assche
On 9/17/18 9:08 AM, Avri Altman wrote: +*Caveat emptor*: The driver makes no further input validations and sends the +UPIU to the device as it is. Open the bsg device in /dev/ufs-bsg-%0:0 and +send SG_IO with the applicable sg_io_v4: It's not clear to me what %0:0 stands for. Otherwise this