Re: [PATCHv2 06/14] libata: Check log page directory before accessing pages

2016-04-13 Thread Hannes Reinecke
On 04/13/2016 08:08 PM, Tejun Heo wrote: > On Tue, Apr 12, 2016 at 08:47:50AM +0200, Hannes Reinecke wrote: >> +log_pages = get_unaligned_le16(>sector_buf[log_index]); >> +if (!log_pages) { >> +ata_dev_warn(dev, >> + "NCQ Send/Recv Log not supported\n");

Re: [PATCHv2 06/14] libata: Check log page directory before accessing pages

2016-04-13 Thread Tejun Heo
On Tue, Apr 12, 2016 at 08:47:50AM +0200, Hannes Reinecke wrote: > + log_pages = get_unaligned_le16(>sector_buf[log_index]); > + if (!log_pages) { > + ata_dev_warn(dev, > + "NCQ Send/Recv Log not supported\n"); Shouldn't this be an info message?

[PATCHv2 06/14] libata: Check log page directory before accessing pages

2016-04-12 Thread Hannes Reinecke
When reading the NCQ Send/Recv log it might actually not supported, thereby causing irritating messages 'READ LOG DMA EXT failed'. Instead we should be reading the log directory first to figure out if the log is actually supported before trying to access it. Signed-off-by: Hannes Reinecke