Re: [PATCHv3 3/5] scsi_devinfo: Reformat blacklist flags

2017-08-15 Thread Hannes Reinecke
On 08/16/2017 12:52 AM, Bart Van Assche wrote: > On Fri, 2017-08-11 at 16:23 +0200, Hannes Reinecke wrote: >> +typedef __u32 __bitwise sdev_bflags_t; >> + >> +/* Only scan LUN 0 */ >> +#define BLIST_NOLUN ((__force sdev_bflags_t)(1 << 0)) > > Hello Hannes, > > Is the new typedef used

Re: [PATCHv3 3/5] scsi_devinfo: Reformat blacklist flags

2017-08-15 Thread Bart Van Assche
On Fri, 2017-08-11 at 16:23 +0200, Hannes Reinecke wrote: > +typedef __u32 __bitwise sdev_bflags_t; > + > +/* Only scan LUN 0 */ > +#define BLIST_NOLUN ((__force sdev_bflags_t)(1 << 0)) Hello Hannes, Is the new typedef used anywhere outside the BLIST flag definitions? If not, how about

[PATCHv3 3/5] scsi_devinfo: Reformat blacklist flags

2017-08-11 Thread Hannes Reinecke
Reformat blacklist flags to make the values easier to read and to enhance error checking. Signed-off-by: Hannes Reinecke --- include/scsi/scsi_devinfo.h | 77 ++--- 1 file changed, 51 insertions(+), 26 deletions(-) diff --git