Re: [RFC] How to implement linux_block commands in scsi midlayer

2007-02-19 Thread James Bottomley
On Sat, 2007-02-17 at 23:12 -0500, Douglas Gilbert wrote: > IOW don't do it! > > Better would be to flag the request for internal use. This would be my opinion too. We're trying to move away from encapsulated commands wherever we can (although we're definitely not there yet). The idea is that t

Re: [RFC] How to implement linux_block commands in scsi midlayer

2007-02-19 Thread Elias Oltmanns
[ cc-ing Jens so he can intervene in case I got him wrong in the first place. ] Hi Doug, Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Elias, > If you want to define a SCSI operation code for > internal use within the kernel, please make sure > that the byte isn't in the range 0 to 255 (inclusive)

Re: [RFC] How to implement linux_block commands in scsi midlayer

2007-02-17 Thread Douglas Gilbert
Elias, If you want to define a SCSI operation code for internal use within the kernel, please make sure that the byte isn't in the range 0 to 255 (inclusive). Those ones are either t10 defined, reserved or vendor specific for logical_unit or target use. IOW don't do it! Better would be to flag th

[RFC] How to implement linux_block commands in scsi midlayer

2007-02-17 Thread Elias Oltmanns
Hi there, in 2.6.19 the request type REQ_TYPE_LINUX_BLOCK has been introduced. This is meant for generic block layer commands to the lower level drivers. I'd like to use this mechanism for a generic queue freezing and disk parking facility. The idea is to issue a command like REQ_LB_OP_PROTECT to