Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-04 Thread Tomas Henzl
On 07/31/2014 05:16 PM, scame...@beardog.cce.hp.com wrote: On Thu, Jul 31, 2014 at 03:56:13PM +0200, Tomas Henzl wrote: Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I

Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-04 Thread Tomas Henzl
On 08/01/2014 06:40 PM, Webb Scales wrote: On 7/31/14 9:56 AM, Tomas Henzl wrote: In cmd_tagged_alloc Thus, there should never be a collision here between two requests if this is true you don't need the refcount and just a simple flag were sufficient for your other needs. (And maybe you get to

Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-01 Thread Webb Scales
On 7/31/14 9:56 AM, Tomas Henzl wrote: In cmd_tagged_alloc Thus, there should never be a collision here between two requests if this is true you don't need the refcount and just a simple flag were sufficient for your other needs. (And maybe you get to ~971k IOPS..) :-) The code previously had

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread Tomas Henzl
Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I posted in June and add it to your series or review in the list. Thanks. other comments see below Hi Tomas, Thanks for

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread scameron
On Thu, Jul 31, 2014 at 03:56:13PM +0200, Tomas Henzl wrote: Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I posted in June and add it to your series or review in the

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread scameron
On Sun, Jul 27, 2014 at 05:24:46PM +0200, Hannes Reinecke wrote: On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-30 Thread Tomas Henzl
On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph Hellwig's scsi-mq.4 branch which may be found here:

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-30 Thread Webb Scales
Hi Tomas, Thanks for taking a look and for the feedback. I'm actually the one responsible for the changes you refer to, so I'll try to address your comments. On 7/30/14 10:55 AM, Tomas Henzl wrote: I'm not sure if I got it right, it seems it uses the same cmd_pool for both alloc function,

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-27 Thread Hannes Reinecke
On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph Hellwig's scsi-mq.4 branch which may be found here:

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-26 Thread Christoph Hellwig
Christoph Hellwig (1): reserve block tags in scsi host So you found this one useful. This begs the question how we should move forward with it, as it will only work with the blk-mq path in it's current form. I can see three ways: - we implement equivalent functionality in the old block

[RFC] hpsa: work in progress lockless monster patches

2014-07-25 Thread scameron
hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph Hellwig's scsi-mq.4 branch which may be found here: git://git.infradead.org/users/hch/scsi.git We've been working for a long time on a