Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Muli Ben-Yehuda wrote: On Mon, Jan 22, 2007 at 01:21:28AM +0200, Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag Some architecture use 'enum dma_data_direction' and some 'int

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Douglas Gilbert wrote: Benny Halevy wrote: Douglas Gilbert wrote: Perhaps the right use of DMA_BIRECTIONAL needs to be defined. Could it be used with a XDWRITE(10) SCSI command defined in sbc3r07.pdf at http://www.t10.org ? I suspect using two scatter gather lists would be a better

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Muli Ben-Yehuda
On Tue, Jan 23, 2007 at 03:45:00PM +0200, Benny Halevy wrote: +static inline int dma_uni_dir(enum dma_data_direction dir) +{ + return (dir == DMA_TO_DEVICE) || (dir == DMA_FROM_DEVICE) || + (dir == DMA_NONE); +} While this doesn't look very useful. Why is DMA_NONE a

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Muli Ben-Yehuda wrote: On Tue, Jan 23, 2007 at 03:45:00PM +0200, Benny Halevy wrote: +static inline int dma_uni_dir(enum dma_data_direction dir) +{ + return (dir == DMA_TO_DEVICE) || (dir == DMA_FROM_DEVICE) || + (dir == DMA_NONE); +} While this doesn't look very useful. Why is

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-22 Thread Douglas Gilbert
Benny Halevy wrote: Douglas Gilbert wrote: Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag - Add new API to query request direction. - Adjust existing API and implementation. - Cleanup wrong use

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-22 Thread James Bottomley
On Mon, 2007-01-22 at 10:05 -0500, Douglas Gilbert wrote: Perhaps the right use of DMA_BIRECTIONAL needs to be defined. Could it be used with a XDWRITE(10) SCSI command defined in sbc3r07.pdf at http://www.t10.org ? I suspect using two scatter gather lists would be a better approach. -

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-22 Thread William Studenmund
On Jan 21, 2007, at 10:06 PM, Benny Halevy wrote: Douglas Gilbert wrote: Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag - Add new API to query request direction. - Adjust existing API and

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-21 Thread Douglas Gilbert
Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag - Add new API to query request direction. - Adjust existing API and implementation. - Cleanup wrong use of DMA_BIDIRECTIONAL - Introduce new

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-21 Thread Muli Ben-Yehuda
On Mon, Jan 22, 2007 at 01:21:28AM +0200, Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag Some architecture use 'enum dma_data_direction' and some 'int dma_data_direction'. The consensus was to move

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-21 Thread Benny Halevy
Douglas Gilbert wrote: Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag - Add new API to query request direction. - Adjust existing API and implementation. - Cleanup wrong use of DMA_BIDIRECTIONAL