Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-11 Thread Christoph Hellwig
On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > We no longer have the bvec merge functions so the original reason given > in the thread/patch Bart referenced is no longer valid. > > Offlist it was suggested that dropping the argument from submit_bio > might still improve

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-10 Thread Mike Christie
On 11/07/2015 04:23 AM, Christoph Hellwig wrote: > On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote: >>> If you have to touch submit_bio() and submit_bio_wait(), how about >>> requiring the callers of these functions to set the cmd and flags >>> arguments in the bio structure and to

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-07 Thread Christoph Hellwig
On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote: > > If you have to touch submit_bio() and submit_bio_wait(), how about > > requiring the callers of these functions to set the cmd and flags > > arguments in the bio structure and to leave out the cmd and flags > > arguments from the

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread Bart Van Assche
On 11/04/2015 08:32 AM, mchri...@redhat.com wrote: There are a couple new block layer commands we are trying to add support for in the near term: compare and write http://www.spinics.net/lists/target-devel/msg07826.html copy offload/extended copy/xcopy

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread Mike Christie
On 11/04/2015 10:49 AM, Bart Van Assche wrote: > Hello Mike, > > If you have to touch submit_bio() and submit_bio_wait(), how about > requiring the callers of these functions to set the cmd and flags > arguments in the bio structure and to leave out the cmd and flags > arguments from the