Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread James Bottomley
On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: } void sas_device_set_phy(struct domain_device *dev, struct sas_port *port) diff --git a/drivers/scsi/libsas/sas_port.c

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: } void sas_device_set_phy(struct

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: I don't have a libsas environment handy, I worked with Praveen to validate the

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 10:55 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:07 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams

RE: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Praveen Murali
-Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: Monday, July 27, 2015 11:25 AM To: James Bottomley Cc: Christoph Hellwig; Praveen Murali; linux-scsi; sta...@vger.kernel.org Subject: Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:38 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: No, that seems to be the intent of the prior code. The reason port visibility goes immediately (along with all associated phys), is that the port is ready for reuse as soon as sas_deform_port()

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-22 Thread Dan Williams
On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote: Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-06-21 Thread Hannes Reinecke
On 06/18/2015 05:22 AM, Dan Williams wrote: Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas sas_phye_loss_of_signal calls sas_deform_port sas_deform_port posts a DISCE_DESTRUCT

[for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-06-17 Thread Dan Williams
Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas sas_phye_loss_of_signal calls sas_deform_port sas_deform_port posts a DISCE_DESTRUCT event (sas_unregister_domain_devices-