Hi David,
can you give as any hint? We're running aroud 120 Adaptec Controllers
and i don't want to replace them all...
Greets,
Stefan
Am 27.09.2018 um 14:23 schrieb Stefan Priebe - Profihost AG:
>
> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac:
>> Le Wed, 19 Sep 2018 08:10:41 +0200
>>
On 2018-10-16 10:38 a.m., Jens Axboe wrote:
We just need to free the request here. Additionally, this is
currently wrong for a queue that's using MQ currently, it'll
crash.
Surprise removals are difficult code paths to check. That snippet
is after the request has been generated and before the
Jens,
>> How about adding Hannes' Signed-off-by? See also
>> https://www.spinics.net/lists/linux-scsi/msg123488.html.
>
> I had no idea this existed, I'll just replace with that one instead
> and your reviewed-by (and mine).
> Martin, is this queued up?
Nope, I was waiting for Hannes to
On 10/16/18 9:09 AM, Martin K. Petersen wrote:
>
> Jens,
>
>>> How about adding Hannes' Signed-off-by? See also
>>> https://www.spinics.net/lists/linux-scsi/msg123488.html.
>>
>> I had no idea this existed, I'll just replace with that one instead
>> and your reviewed-by (and mine).
>
>> Martin,
On 10/16/18 8:55 AM, Bart Van Assche wrote:
> On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote:
>> This check is only viable for non scsi-mq. Since that is going away,
>> kill this legacy check.
>>
>> Cc: Bart Van Assche
>> Cc: Parav Pandit
>> Cc: linux-scsi@vger.kernel.org
>> Signed-off-by:
On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote:
> This check is only viable for non scsi-mq. Since that is going away,
> kill this legacy check.
>
> Cc: Bart Van Assche
> Cc: Parav Pandit
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Jens Axboe
> ---
>
On Sun, 14 Oct 2018, 11:59am, Christoph Hellwig wrote:
> External Email
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Johannes Thumshirn
> ---
>
On Fri, Oct 12, 2018 at 12:20 AM Christoph Hellwig wrote:
>
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 150 ++--
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 16 +--
>
On Tue, 16 Oct 2018 00:42:57 -0400, Martin K. Petersen wrote:
> > I guess I'll resend entire series in future to avoid false kbuild
> > reports.
>
> Yes, please. Patchwork can't handle individual patches getting updated
> either.
Okay, will do.
> Applied to 4.20/scsi-queue.
Thanks Martin.
Bart,
> During the 2018 edition of LSF/MM there was a session about increasing
> SCSI disk probing concurrency. This patch series implements what has
> been proposed during that session, namely: - Make sure that the driver
> core is aware of asynchronous SCSI LUN probing. - Avoid unnecessary
>
David,
> This patch is a v3 respin of an individual patch within the series:
> [PATCH v2 0/5] target: improve Data-Out and NOP timeout error
> reporting The sess declaration is provided in [PATCH v2 3/5].
>
> I guess I'll resend entire series in future to avoid false kbuild
> reports.
Yes,
Ewan,
>> +if (!elsiocb->context1)
>> +goto dropit;
>> +
>> if ((cmd & ELS_CMD_MASK) == ELS_CMD_RSCN) {
>> cmd &= ELS_CMD_MASK;
>> }
>
> Well, that's fine. But if lpfc_nlp_get() can return NULL, because the
> ndlp structure could be going away, perhaps we
Hannes,
> here are some patches for PRLI issues in libfc we've come across
> recently. The libfc ones are pretty straightforward, but the scsi
> state machine one probably warrants some discussion. What happened
> was that in some fabrics the RSCN might get lost or incompletely
> reseived.
Christoph,
> Mostly to avoid methods calls for dma mapping, but also to tidy up
> a few bits found while doing that.
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> dma_alloc_coherent allocates memory that can be used by the cpu and the
> device at the same time, calls to pci_dma_sync_* are not required, and
> in fact actively harmful on some architectures like arm.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux
Christoph,
> The dma_map_sg / dma_unmap_sg APIs called from scsi_dma_map /
> scsi_dma_unmap already transfer memory ownership to the device or cpu
> respectively. Adding additional calls to pci_dma_sync_sg_* will in
> fact lead to data corruption if we end up using swiotlb for some
> reason.
>
On Tue, Oct 02, 2018 at 02:52:23PM -0700, Bart Van Assche wrote:
> Since __device_release_driver() is called with the device lock held
> and since the same device lock is obtained by the functions that
> perform asynchronous probing (driver_attach_async() and
> __device_attach_async_helper()),
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org On
> Behalf Of Christoph Hellwig
> Sent: Sunday, October 14, 2018 9:30 PM
> To: linux-scsi@vger.kernel.org
> Subject: [PATCH 20/28] qedi: fully convert to the generic DMA API
>
> External Email
>
> The driver is currently
> > +
> > + instance->snapdump_prop =
> > + pci_alloc_consistent(pdev,
> > +sizeof(struct
> MR_SNAPDUMP_PROPERTIES),
> > +>snapdump_prop_h);
>
> No new calls to the PCI DMA API please.
>
>
On 10/2/18 2:52 PM, Bart Van Assche wrote:
During the 2018 edition of LSF/MM there was a session about increasing SCSI
disk probing concurrency. This patch series implements what has been proposed
during that session, namely:
- Make sure that the driver core is aware of asynchronous SCSI LUN
> +
> + instance->snapdump_prop =
> + pci_alloc_consistent(pdev,
> + sizeof(struct
> MR_SNAPDUMP_PROPERTIES),
> + >snapdump_prop_h);
No new calls to the PCI DMA API please.
Please
On Sun, 14 Oct 2018 11:43:34 +0800, kbuild test robot wrote:
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on target/master]
> [also build test ERROR on v4.19-rc7 next-20181012]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on target/master]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on target/master]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
> it seems like we do for some reason never actually enable swiotlb
> for 32-bit x86. Before my commit the block bounce buffering papered
> over that for networking, Please try this patch:
>
> diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
> index
On Sat, Oct 13, 2018 at 10:09:52AM -0400, tedheadster wrote:
> Christoph,
> here is all of the newly patched dmesg output. I also added
> 'aic7xxx.a9c7xxx=verbose' for extra information.
Hi Matthew,
it seems like we do for some reason never actually enable swiotlb
for 32-bit x86. Before my
On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote:
> On 10/12/18 1:36 PM, Laurence Oberman wrote:
> > While I have for the longest time used 4.5 as a base for my F/C
> jammer
> > that I use every day here in our lab I recently added more jammer
> code
> > so I decided to test this all on
Christoph,
here is all of the newly patched dmesg output. I also added
'aic7xxx.a9c7xxx=verbose' for extra information.
Matthew
[0.00] Linux version 4.18.12.pentium4-xeon-christoph+
(root@pentium4) (gcc version 5.4.0 (Gentoo 5.4.0-r4 p1.8, pie-0.6.5))
#525 SMP PREEMPT Sat Oct 13
On Fri, 12 Oct 2018 09:11:27 -0700, Bart Van Assche wrote:
> There have been too many problems with strcpy() and buffer overflows in the
> past. If the source and destination strings both have the same size, please
> add a BUILD_BUG_ON() statement that verifies that at compile time. If that
>
On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> Mostly to avoid methods calls for dma mapping, but also to tidy up
> a few bits found while doing that.
>
> Changes since v2:
> - add back required DMA_NONE check
> - also clear sense_ptr for PIO transfers
> - remove the pointless union in
On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote:
> > > struct scatterlist *sg = scsi_sglist(cmd);
> > > - int dir = cmd->sc_data_direction;
> > > - int total, i;
> > > + int total = 0, i;
> > >
> > > - if (dir == DMA_NONE)
> > > -
On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote:
> > struct scatterlist *sg = scsi_sglist(cmd);
> > - int dir = cmd->sc_data_direction;
> > - int total, i;
> > + int total = 0, i;
> >
> > - if (dir == DMA_NONE)
> > - return;
> > -
>
> Removing this DMA_NONE test
Hi Ted,
thanks for the dmesg. This shows your HBA doesn't even support the
odd 39-bit addressing. Now the real question is why we don't use
swiotlb. For that I'd like to see the whole dmesg from the very
beinning if you have it. Also it seems this boot didn't have the
WARN_ON_ONCE I sent you
> That isn't a limit, just a reporting clause - the real check is this
> line a little above:
>
> if (unlikely(dev && !dma_capable(dev, dma_addr, size))) {
>
> which is purely based on the dma mask. So for some reason we must
> be in 32-bit only mode for the dma-mask, and not actually
On 10/12/18 1:36 PM, Laurence Oberman wrote:
> While I have for the longest time used 4.5 as a base for my F/C jammer
> that I use every day here in our lab I recently added more jammer code
> so I decided to test this all on latest upstream.
>
> Booting the target server on my 4.5 kernel with
> On Fri, 12 Oct 2018, Christoph Hellwig wrote:
>
> >
> > > diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
> > > index eb551f3cc471..85d067889a9b 100644
> > > --- a/drivers/scsi/mac_esp.c
> > > +++ b/drivers/scsi/mac_esp.c
> > > @@ -58,8 +58,7 @@ static struct esp *esp_chips[2];
>
On Thu, 11 Oct 2018, Christoph Hellwig wrote:
> diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
> index 90604bff8dd2..73fcbd65b9fe 100644
> --- a/drivers/scsi/esp_scsi.c
> +++ b/drivers/scsi/esp_scsi.c
> @@ -369,19 +369,25 @@ static void esp_map_dma(struct esp *esp, struct
>
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-sas.c | 38
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-9xxx.c | 50
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-.c | 20 ++--
>
On Fri, 2018-10-12 at 12:01 +0200, David Disseldorp wrote:
> +void iscsit_fill_cxn_timeout_err_stats(struct iscsi_session *sess)
> +{
> + struct iscsi_portal_group *tpg = sess->tpg;
> + struct iscsi_tiqn *tiqn = tpg->tpg_tiqn;
> +
> + if (!tiqn)
> + return;
> +
> +
On Fri, Oct 12, 2018 at 04:45:57PM +1100, Finn Thain wrote:
> > + if (esp->flags & ESP_FLAG_NO_DMA_MAP)
> > + return;
> > +
> > + dma_unmap_single(esp->dev, ent->sense_dma, SCSI_SENSE_BUFFERSIZE,
> > +DMA_FROM_DEVICE);
> > + ent->sense_ptr = NULL;
> > +}
> > +
>
On Fri, Oct 12, 2018 at 04:47:23PM +1100, Finn Thain wrote:
> > + esp->dev = >dev;
> >
> > esp->command_block = kzalloc(16, GFP_KERNEL);
> > if (!esp->command_block)
>
>
> Isn't this missing the corresponding dev_set_drvdata() in esp_mac_probe()?
> Also conversion to
In megasas_init_adapter_fusion(), max_mfi_cmds is being calcuated as
(MEGASAS_FUSION_INTERNAL_CMDS + MEGASAS_FUSION_IOCTL_CMDS).
max_mfi_cmds can be used in megasas_configure_queue_sizes.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Fri, Oct 12, 2018 at 11:30:10AM +0900, Damien Le Moal wrote:
> Expose through sysfs the nr_zones field of struct request_queue.
> Exposing this value helps in debugging disk issues as well as
> facilitating scripts based use of the disk (e.g. blktests).
>
> For zoned block devices, the
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Fri, Oct 12, 2018 at 09:41:28AM +0200, Hannes Reinecke wrote:
>> +{
>> +return 0;
>> +}
>> #endif /* CONFIG_BLK_DEV_ZONED */
>> static inline bool rq_is_sync(struct request *rq)
>>
> Actually, we should be checking whether we can't blank out this attribute
> via the is_visible
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Christoph Hellwig 于2018年10月11日周四 下午9:38写道：
>
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Jack Wang
Thanks,
Jack
On Thu, Oct 11, 2018 at 08:49:58PM +0200, Christoph Hellwig wrote:
> @@ -9026,19 +9026,13 @@ static void qla4xxx_remove_adapter(struct pci_dev
> *pdev)
> */
> static void qla4xxx_config_dma_addressing(struct scsi_qla_host *ha)
> {
> - int retval;
> -
Can you zap that:
At exit, the
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Thu, Oct 11, 2018 at 08:49:42PM +0200, Christoph Hellwig wrote:
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/atp870u.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On 10/12/18 4:30 AM, Damien Le Moal wrote:
Drivers exposing zoned block devices have to initialize and maintain
correctness (i.e. revalidate) of the device zone bitmaps attached to
the device request queue (seq_zones_bitmap and seq_zones_wlock).
To simplify coding this, introduce a generic
On Thu, Oct 11, 2018 at 08:49:41PM +0200, Christoph Hellwig wrote:
> @@ -1124,7 +1124,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for SCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_scb);
> - host->scb_virt = pci_zalloc_consistent(pdev,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On 10/12/18 4:30 AM, Damien Le Moal wrote:
There is no point in allocating more zone descriptors than the number of
zones a block device has for doing a zone report. Avoid doing that in
blkdev_report_zones_ioctl() by limiting the number of zone decriptors
allocated internally to process the user
On 10/12/18 4:30 AM, Damien Le Moal wrote:
The 32 bits overflow check for the zone size value is already done
within sd_zbc_check_zones() with the test:
} else if (logical_to_sectors(sdkp->device, zone_blocks) > UINT_MAX) {
so there is no need to check again for an out of range value in
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
@vger.kernel.org; linux-...@vger.kernel.org;
Andy Shevchenko; Sathya Prakash; Sreekanth Reddy;
linux-ker...@vger.kernel.org; b...@kernel.crashing.org; rus...@russell.cc;
sbobr...@linux.ibm.com; Oliver
Subject: Re: [PATCH v4 1/6] mpt3sas: Introduce
mpt3sas_base_pci_device_is_available
On Tue, Oct 2, 2018 at 7:34
On Thu, 11 Oct 2018, Christoph Hellwig wrote:
> esp->dev is a void pointer that points either to a struct device, or a
> struct platform_device. As we can easily get from the device to the
> platform_device if needed change it to always point to a struct device
> and properly type the pointer to
On Thu, 11 Oct 2018, Christoph Hellwig wrote:
> index 90604bff8dd2..73fcbd65b9fe 100644
> --- a/drivers/scsi/esp_scsi.c
> +++ b/drivers/scsi/esp_scsi.c
> @@ -369,19 +369,25 @@ static void esp_map_dma(struct esp *esp, struct
> scsi_cmnd *cmd)
> {
> struct esp_cmd_priv *spriv =
On 10/11/18 1:49 PM, Christoph Hellwig wrote:
Switch from the legacy PCI DMA API to the generic DMA API.
Signed-off-by: Christoph Hellwig
Tested-by: Don Brace
Acked-by: Don Brace
On 10/11/18 1:50 PM, Christoph Hellwig wrote:
The driver is currently using an odd mix of legacy PCI DMA API and
generic DMA API calls, switch it over to the generic API entirely.
Signed-off-by: Christoph Hellwig
Tested-by: Don Brace
Acked-by: Don Brace
---
So in v2 you moved the #ifdef CONFIG_BLK_DEV_ZONED
so that nr_zones is always present? It was previously
changed to keep the request_queue size smaller.
Would make more sense to make the nr_zones sysfs
code here conditional on CONFIG_BLK_DEV_ZONED?
-Ewan
On Thu, 2018-10-11 at 16:09 +0900,
On 11/10/2018 14:32, Ming Lei wrote:
On Thu, Oct 11, 2018 at 02:12:11PM +0100, John Garry wrote:
On 11/10/2018 11:15, Christoph Hellwig wrote:
On Thu, Oct 11, 2018 at 10:59:11AM +0100, John Garry wrote:
blk-mq tags are always per-host (which has actually caused problems for
ATA, which is
On Thu, Oct 11, 2018 at 02:12:11PM +0100, John Garry wrote:
> On 11/10/2018 11:15, Christoph Hellwig wrote:
> > On Thu, Oct 11, 2018 at 10:59:11AM +0100, John Garry wrote:
> > >
> > > > blk-mq tags are always per-host (which has actually caused problems for
> > > > ATA, which is now using its own
On 11/10/2018 11:15, Christoph Hellwig wrote:
On Thu, Oct 11, 2018 at 10:59:11AM +0100, John Garry wrote:
blk-mq tags are always per-host (which has actually caused problems for
ATA, which is now using its own per-device tags).
So, for example, if Scsi_host.can_queue = 2048 and
> On Oct 11, 2018, at 12:56 AM, Nicholas A. Bellinger
> wrote:
>
> Hello MNC & Co,
>
> On Wed, 2018-10-10 at 11:58 -0500, Mike Christie wrote:
>> On 10/09/2018 10:23 PM, Nicholas A. Bellinger wrote:
>>> From: Nicholas Bellinger
>>>
>>> With the addition of commit 00d909a107 in v4.19-rc,
Add Amit Shah.
After some tests, we found:
- the virtio serial port number is inversely proportional to the iSCSI
virtio-blk-pci performance.
If we set the virio-serial ports to 2("), the performance downgrade
is minimal.
- use local disk/ram disk as virtio-blk-pci disk, the performance
On Thu, Oct 11, 2018 at 10:59:11AM +0100, John Garry wrote:
>
> > blk-mq tags are always per-host (which has actually caused problems for
> > ATA, which is now using its own per-device tags).
> >
>
> So, for example, if Scsi_host.can_queue = 2048 and Scsi_host.nr_hw_queues =
> 16, then rq tags
On 11/10/2018 07:36, Christoph Hellwig wrote:
On Wed, Oct 10, 2018 at 09:58:25PM -0400, Martin K. Petersen wrote:
This is because the IPTT index must be a unique value per HBA. However,
if we switched to SCSI MQ, the block layer tag becomes unique per queue,
and not per HBA.
That doesn't
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Wed, Oct 10, 2018 at 10:40:12PM -0700, Nicholas A. Bellinger wrote:
> Hey Peter & Co,
>
> On Wed, 2018-10-10 at 10:43 +0200, Peter Zijlstra wrote:
> > On Wed, Oct 10, 2018 at 03:23:10AM +, Nicholas A. Bellinger wrote:
> > > From: Nicholas Bellinger
> > >
> > > With the addition of commit
On Thu, Oct 11, 2018 at 11:10:36AM +1100, Finn Thain wrote:
> If you do so, can you also eliminate the dev argument to
> scsi_esp_register()?
Sure.
> > - struct platform_device *op = esp->dev;
> > + struct platform_device *op = to_platform_device(esp->dev);
> >
> > - esp->command_block
On Wed, Oct 10, 2018 at 09:58:25PM -0400, Martin K. Petersen wrote:
> > This is because the IPTT index must be a unique value per HBA. However,
> > if we switched to SCSI MQ, the block layer tag becomes unique per queue,
> > and not per HBA.
>
> That doesn't sound right.
blk-mq tags are always
Hello MNC & Co,
On Wed, 2018-10-10 at 11:58 -0500, Mike Christie wrote:
> On 10/09/2018 10:23 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes
> > no
> > signals will be pending for task_struct
Hey Peter & Co,
On Wed, 2018-10-10 at 10:43 +0200, Peter Zijlstra wrote:
> On Wed, Oct 10, 2018 at 03:23:10AM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes
> > no
> > signals will be pending
Avri,
> Here is a proposal to use a bsg endpoint to manage ufs devices.
>
> We will do that by adding a bsg device node to the ufs driver, and use
> it to send UPIU transactions to the ufs device. It will serve as a
> ufs device management infrastructure, for device configuration,
>
401 - 500 of 39577 matches
Mail list logo
