On Wed, 10 Oct 2018, Christoph Hellwig wrote:
> esp->dev is a void pointer that points either to a struct device, or a
> struct platform_device. As we can easily get from the device to the
> platform_device if needed change it to always point to a struct device
> and properly type the pointer to
On Wed, 2018-10-10 at 16:55 +0200, Michal Soltys wrote:
> Hi,
>
> I have a server with old server with lsi2308 ("it" mode) and sas2x36
> expander in front. I've been testing how it handles ssd drives (among
> those if/how it copes with unmap). And it looks like
> stomped on a bug (it's 100%
On Mon, Oct 01, 2018 at 04:57:39PM -0400, tedheadster wrote:
> Christoph,
> I was able to bisect this to your patch "scsi: reduce use of block
> bounce buffers". I am getting the error on a 32-bit Dell PowerEdge
> 6650. It has the aic7xxx integrated onto the motherboard.
>
> Again, here is the
On Tue, 2018-10-09 at 08:30 +0200, Hannes Reinecke wrote:
> lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a
> lock, so there is a chance that it might actually fail. But as we
> never check the return value we'll get a crash in lpfc_nlp_put()
> later on trying to free an invalid
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On 10/8/18 10:22 PM, Ewan D. Milne wrote:
This change would permit a device that was OFFLINE (for any reason)
to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING
Correct.
Obviously that was your intention, but e.g. if a device was put
OFFLINE due to exceeding max_medium_access_timeouts
This change would permit a device that was OFFLINE (for any reason)
to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING
Obviously that was your intention, but e.g. if a device was put
OFFLINE due to exceeding max_medium_access_timeouts a fabric
event and recovery would put it back online.
On Sun, 7 Oct 2018, 1:35am, Hannes Reinecke wrote:
> External Email
>
> From: Hannes Reinecke
>
> When we fail to analyse the payload of a PRLI response we should
> reset the state machine to retry the PRLI; eventually we will be
> getting a proper frame.
> Not doing so will result in a stuck
On Sun, 7 Oct 2018, 1:35am, Hannes Reinecke wrote:
> External Email
>
> From: Thomas Abraham
>
> We should not assume the payload of a PRLI or PLOGI
> respons is always present.
>
> Signed-off-by: Thomas Abraham
> Reviewed-by: Hannes Reinecke
> ---
> drivers/scsi/libfc/fc_rport.c | 14
ecke;
> >Bart Van Assche; James E.J. Bottomley; Martin K. Petersen; linux-
> >s...@vger.kernel.org
> >Cc: Stanislav Nijnikov; Avi Shchislowski; Alex Lemberg; Subhash Jadavani;
> >Vinayak Holikatti
> >Subject: RE: [PATCH v8 0/8] scsi: Add ufs bsg endpoint
> >
>
> On Thu, Oct 04, 2018 at 08:20:30AM +0300, Avri Altman wrote:
> > From: Christoph Hellwig
> >
> > Remove the pointless task_req_upiu and task_rsp_upiu indirections,
> > which are __le32 arrays always cast to given structures and just add
> > the members directly. Also clean up variables names
> >
> > diff --git a/include/uapi/scsi/scsi_bsg_ufs.h
> > b/include/uapi/scsi/scsi_bsg_ufs.h
> > new file mode 100644
> > index 000..4108ce3
> > --- /dev/null
> > +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> > @@ -0,0 +1,74 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * TBD - UFS
> > Add a bsg endpoint that supports UPIUs.
>
> This should probably go into the subject line.
Done.
>
> >
> > For now, just provide an API to allocate and remove
> > ufs-bsg node. We will use this framework to
> > manage ufs devices by sending UPIU transactions.
>
> Please use up to 73
On 10/5/18 5:51 PM, chris.mo...@microchip.com wrote:
> Thanks Hannes,
>
> After some pointers from Shane Seymour I found that the FC and SRP transport
> layers
> have a devloss timer, so that when a device disappears they hold on to the
> target
> information for a time waiting to see if it
2018 8:01 AM
> To: Chris Moore - C33997 ; linux-
> s...@vger.kernel.org
> Subject: Re: Looking for some help understanding error handling
>
> On 10/2/18 11:04 PM, chris.mo...@microchip.com wrote:
> > I'm working on LLDD for a SAS/SATA host adapter, and trying to understand
>
On 10/2/18 11:04 PM, chris.mo...@microchip.com wrote:
I'm working on LLDD for a SAS/SATA host adapter, and trying to understand how
the system handles link loss and recovery.
Say I have a device that gets recognized and attached as sd 12:0:4:0, at
/dev/sdb.
The drive goes offline temporarily,
x-
>s...@vger.kernel.org
>Cc: Stanislav Nijnikov; Avi Shchislowski; Alex Lemberg; Subhash Jadavani;
>Vinayak Holikatti
>Subject: RE: [PATCH v8 0/8] scsi: Add ufs bsg endpoint
>
>Hi, Avri
>
>>We tested it on a Hikey-960 platform with a V4.14 kernel, "modernized"
On Thu, Oct 04, 2018 at 08:20:33AM +0300, Avri Altman wrote:
> Add a bsg endpoint that supports UPIUs.
This should probably go into the subject line.
>
> For now, just provide an API to allocate and remove
> ufs-bsg node. We will use this framework to
> manage ufs devices by sending UPIU
On Thu, Oct 04, 2018 at 08:20:32AM +0300, Avri Altman wrote:
> in preparation to send UPIU requests via bsg.
>
> Signed-off-by: Avri Altman
> Reviewed-by: Bart Van Assche
> ---
> drivers/scsi/ufs/ufs.h | 61 +
> drivers/scsi/ufs/ufshcd.c| 6
On Thu, Oct 04, 2018 at 08:20:30AM +0300, Avri Altman wrote:
> From: Christoph Hellwig
>
> Remove the pointless task_req_upiu and task_rsp_upiu indirections,
> which are __le32 arrays always cast to given structures and just add
> the members directly. Also clean up variables names in use in
12:28 AM
To: Avri Altman; Christoph Hellwig; Johannes Thumshirn; Hannes Reinecke; Bart
Van Assche; James E.J. Bottomley; Martin K. Petersen; linux-scsi@vger.kernel.org
Cc: Stanislav Nijnikov; Avi Shchislowski; Alex Lemberg; Subhash Jadavani;
Vinayak Holikatti
Subject: RE: [PATCH v8 0/8] scsi: Add
Hi, Avri
>We tested it on a Hikey-960 platform with a V4.14 kernel, "modernized" by
>recent bsg and ufs patches.
Which kernel version is V8 based on? I patched to 4.14-rc7, it failed.
Hi Dave,
Am 03.10.2018 um 19:32 schrieb dave.carr...@microchip.com:
>> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac:
>>> Le Wed, 19 Sep 2018 08:10:41 +0200
>>> Stefan Priebe - Profihost AG écrivait:
>>>
Hello,
after upgrading the aacraid driver / kernel from aacraid 50792 to
> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac:
> > Le Wed, 19 Sep 2018 08:10:41 +0200
> > Stefan Priebe - Profihost AG écrivait:
> >
> >> Hello,
> >>
> >> after upgrading the aacraid driver / kernel from aacraid 50792 to
> >> aacraid 50877.
> >>
> >> I get aborted comands every night.
> >>
> >
> > +
> > +/*
> > + * This file intended to be included by both kernel and user space
> > + */
> > +
> > +#define MAX_CDB_SIZE 16
>
> Please rename this constant such that it has either "UFS" or "UTP" in its
> name. This name is too generic for a protocol-specific header file.
Done.
Christoph,
I was able to bisect this to your patch "scsi: reduce use of block
bounce buffers". I am getting the error on a 32-bit Dell PowerEdge
6650. It has the aic7xxx integrated onto the motherboard.
Again, here is the error:
aic7xxx :00:03.0: dma_direct_map_sg: overflow
On Sun, Sep 30, 2018 at 07:28:50PM -0400, tedheadster wrote:
> Hannes,
> I'm getting the following error in a custom configured 4.18 32-bit
> x86 kernel supporting PAE, with 16GiB physical memory. It loops
> infinitely on the error.
>
> aic7xxx :00:03.0: dma_direct_map_sg: overflow
>
On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote:
>
> On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> > The code for getting shost and IOC is redundant so
> > moved that to function "scsih_get_shost_and_ioc".
> > Also checks for NULL are added to IOC and shost.
> >
> >
On Sun, 2018-09-30 at 08:45 +0300, Avri Altman wrote:
> +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * TBD - UFS Transport SGIO v4 BSG Message Support
> + *
> + * Copyright (C) 2011-2013 Samsung India Software Operations
> + */
>
Himanshu,
> This patch fixes commit bcc71cc3cde1468958a3ea859276d8d1a1a68265 which
> misplaced code in worng routines.
>
> Also updated the use of WARN_ON() to WARN_ON_ONCE() to prevent
> flooding log messages.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux
Finn,
> This series addresses issues which became apparent when Michael
> Schmitz tried to use an AztecMonster II SATA/SCSI adapter with a 5380
> host.
>
> That target seems to have some bugs which thoroughly exercise driver
> error paths and EH.
>
> The patch by Hannes Reinecke was
Himanshu,
> This series fixes issues found during out last test cycle.
>
> Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver.
>
> Patch 3 fixes issue discovered during BFS test setup resulting into
> installation failure and hand because driver could not discover BFS
Nilesh,
> Fix kernel NULL pointer dereference,
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We shouldn't allow negative thresholds. I don't know what it would do
> but it can't be good.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Masanari,
> Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in
> commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not
> modified.
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
On Thu, Sep 27, 2018 at 04:35:37PM -0700, Nick Desaulniers wrote:
> On Tue, Sep 25, 2018 at 9:58 PM Nathan Chancellor
> wrote:
> >
> > Clang warns when one enumerated type is implicitly converted to another.
> >
> > drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion
> > from
On Tue, Sep 25, 2018 at 9:58 PM Nathan Chancellor
wrote:
>
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion
> from enumeration type 'enum bfa_lport_aen_event' to different
> enumeration type 'enum
On Thu, Sep 27, 2018 at 7:01 AM Christoph Hellwig wrote:
>
> On Thu, Sep 27, 2018 at 06:32:47AM +, Avri Altman wrote:
> > Also, in this context there is the series in
> > https://www.spinics.net/lists/linux-scsi/msg123479.html
> > which allows to send UPIUs via a bsg device.
> >
> > It's not
> query commands
> qla2xxx: Move log messages before issuing command to firmware
>
> Himanshu Madhani (1):
> qla2xxx: Fix driver hang when FC-NVMe LUNs are configured
>
> Quinn Tran (5):
> qla2xxx: fix nvme session hang on unload
> qla2xxx: Fix NVMe Target dis
On Thu, Sep 27, 2018 at 01:47:46PM -0500, Bjorn Helgaas wrote:
> mpt3sas_wait_for_commands_to_complete(...)
> {
> ...
> + if (!mpt3sas_base_pci_device_is_available(ioc))
> +return;
>
> # In the definitive case, we returned above. If we get here, we
> # think the device
[+cc Ben, Russell, Sam, Oliver in case they have pertinent experience from
powerpc error handling; thread begins at
https://lore.kernel.org/linux-pci/1537935759-14754-1-git-send-email-suganath-prabu.subram...@broadcom.com/]
On Thu, Sep 27, 2018 at 09:03:27AM +0200, Lukas Wunner wrote:
> On Wed,
On Thu, Sep 27, 2018 at 06:16:44AM +, Avri Altman wrote:
> In V6, we removed the host and device indices from the bsg device name,
> But I have some seconds thoughts about it.
>
> We are using the bsg device in passthrough mode (bsg_transport_ops),
> But the device name: "ufs-bsg" does not
On Thu, Sep 27, 2018 at 06:32:47AM +, Avri Altman wrote:
> Also, in this context there is the series in
> https://www.spinics.net/lists/linux-scsi/msg123479.html
> which allows to send UPIUs via a bsg device.
>
> It's not a provisioning series per-se like Evan's and Sayali's.
> It covers the
>
> > -ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd)
> > +int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command
> *uic_cmd)
> > {
> > int ret;
> > unsigned long flags;
> > @@ -2081,6 +2080,7 @@ static inline u8 ufshcd_get_upmcrs(struct ufs_hba
> *hba)
>
>
> > + case UPIU_TRANSACTION_QUERY_REQ:
> > + qr = _request->upiu_req.qr;
> > + if (qr->opcode == UPIU_QUERY_OPCODE_READ_DESC)
> > + goto not_supported;
> > +
> > + if (ufs_bsg_get_query_desc_size(hba, qr, _len))
> > + goto
> + case UPIU_TRANSACTION_QUERY_REQ:
> + qr = _request->upiu_req.qr;
> + if (qr->opcode == UPIU_QUERY_OPCODE_READ_DESC)
> + goto not_supported;
> +
> + if (ufs_bsg_get_query_desc_size(hba, qr, _len))
> + goto
> -ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd)
> +int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd)
> {
> int ret;
> unsigned long flags;
> @@ -2081,6 +2080,7 @@ static inline u8 ufshcd_get_upmcrs(struct ufs_hba *hba)
>
Am 27.09.2018 um 12:59 schrieb Emmanuel Florac:
> Le Wed, 19 Sep 2018 08:10:41 +0200
> Stefan Priebe - Profihost AG écrivait:
>
>> Hello,
>>
>> after upgrading the aacraid driver / kernel from aacraid 50792 to
>> aacraid 50877.
>>
>> I get aborted comands every night.
>>
>
> I have exactly
> -Original Message-
> From: Colin King
> Sent: Wednesday, September 26, 2018 6:39 PM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; James E . J . Bottomley ;
> Martin K . Petersen ; linux-scsi@vger.kernel.org
> Cc: kernel-janit...@vger.kernel.org;
Le Mon, 24 Sep 2018 08:11:20 +0200
Stefan Priebe - Profihost AG écrivait:
> all series 6 controllers are those with problems when high load
> happens.
>
As I mentioned in my messages to the ML since late june, the driver
doesn't work either with 7xx5 and 8xx5 controllers. Who's maintaining
Le Sun, 23 Sep 2018 20:22:56 +0200
Stefan Priebe - Profihost AG écrivait:
> Am 22.09.2018 um 23:40 schrieb Bart Van Assche:
> > On 9/18/18 11:10 PM, Stefan Priebe - Profihost AG wrote:
> >> after upgrading the aacraid driver / kernel from aacraid 50792 to
> >> aacraid 50877.
> >
> > The
Le Wed, 19 Sep 2018 08:10:41 +0200
Stefan Priebe - Profihost AG écrivait:
> Hello,
>
> after upgrading the aacraid driver / kernel from aacraid 50792 to
> aacraid 50877.
>
> I get aborted comands every night.
>
I have exactly the same problem since 4.15 was out, and nobody
answered...
Hi Bjorn,
Thanks for reviewing.
On Thu, Sep 27, 2018 at 2:33 AM Bjorn Helgaas wrote:
>
> On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote:
> > Introduce mpt3sas_wait_for_ioc_to_operational.
> >
> > This section of code "wait for IOC to be operational"
> > is used in many places
Bart/Christoph,
> + */
> +int ufs_bsg_probe(struct ufs_hba *hba)
> +{
> + struct device *bsg_dev = >bsg_dev;
> + struct Scsi_Host *shost = hba->host;
> + struct device *parent = >shost_gendev;
> + struct request_queue *q;
> + int ret;
> +
> + device_initialize(bsg_dev);
>
>
> Avri,
>
> > this looks generally good to me, but I'd suggest two small tweaks:
> >
> > - please split out a new prep patch that creates
> >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
> >new file
> > +
> > +/**
> > + * ufshcd_exec_raw_upiu_cmd - API function for sending raw upiu
> commands
> > + * @hba: per-adapter instance
> > + * @req_upiu: upiu request
> > + * @rsp_upiu: upiu reply - only 8 DW as we do not support scsi
> commands
> > + * @msgcode: message code, one of
> Hi Avri,
>
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Done.
From: Quinn Tran
This patch fixes issue where driver clears Nport ID map
instead of marking handle in use. Once driver clears
NPort ID from the database, it can reuse same NPort ID
resulting in a PLOGI failure.
Fixes: a084fd68e1d2 ("scsi: qla2xxx: Fix re-login for Nport Handle in use
Trivial nits/questions. In subject:
s/Introdude/Introduce/
s/ / / (remove double space)
s/\.//(remove trailing period, also appears in patches 4, 5, 6)
On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> The code for getting shost and IOC is redundant so
> moved
On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> The code for getting shost and IOC is redundant so
> moved that to function "scsih_get_shost_and_ioc".
> Also checks for NULL are added to IOC and shost.
>
> Signed-off-by: Suganath Prabu S
> ---
>
On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote:
> Introduce mpt3sas_wait_for_ioc_to_operational.
>
> This section of code "wait for IOC to be operational"
> is used in many places across the driver,
> and hence moved this section of code in to the function
>
Hi Anil,
I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.19-rc5 next-20180926]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Anil,
I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.19-rc5 next-20180926]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Avri,
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Also, when you
> On Sep 20, 2018, at 3:02 AM, Dan Carpenter wrote:
>
> External Email
>
> We shouldn't allow negative thresholds. I don't know what it would do
> but it can't be good.
>
> Fixes: 8b4673ba3a1b ("scsi: qla2xxx: Add support for ZIO6 interrupt
> threshold")
> Signed-off-by: Dan Carpenter
>
> On Sep 26, 2018, at 7:34 AM, Christoph Hellwig wrote:
>
> External Email
>
> Please send this to linux-nvme and CC the nvme-fc maintainer.
>
> Without an ACK from the latter, I'll have to NACK it with my nvme
> maintainer hat on.
Sure. will send series to the requested maintainers.
On Fri, Sep 21, 2018 at 12:44:22PM +0300, Avri Altman wrote:
> The UFS host software uses a combination of a host register set,
> and Transfer Request Descriptors in system memory to communicate
> with host controller hardware. In its mmio space, a separate places
> are assigned to UTP Transfer
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
Hi Avri,
this looks generally good to me, but I'd suggest two small tweaks:
- please split out a new prep patch that creates
include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
- pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
new file
Please send this to linux-nvme and CC the nvme-fc maintainer.
Without an ACK from the latter, I'll have to NACK it with my nvme
maintainer hat on.
Per,
>>We have it at error level because many consumer devices lie about
>>having caches and we would like the users to know that their data
>>integrity may be at risk.
>
> There are users that get confused by these errors thinking something
> is broken.
Something is broken: Their hardware!
>
On Tue, Sep 25, 2018 at 1:29 PM Suganath Prabu Subramani
wrote:
>
> On Tue, Sep 25, 2018 at 3:22 PM Andy Shevchenko
> wrote:
> >
> > On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani
> > wrote:
> >
> > > > > + pr_err(MPT3SAS_FMT
> > > > > + "%s: pci error
On Tue, Sep 25, 2018 at 3:22 PM Andy Shevchenko
wrote:
>
> On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani
> wrote:
>
> > > > + pr_err(MPT3SAS_FMT
> > > > + "%s: pci error recovery reset or"
> > > > + " pci device unplug occurred\n",
>
On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani
wrote:
> > > + pr_err(MPT3SAS_FMT
> > > + "%s: pci error recovery reset or"
> > > + " pci device unplug occurred\n",
> >
> > This should be just one line.
> Above line crosses over 80
Hi Andy,
I forgot to add Lukas in last patch CC list, But i have sent a note
regarding the updated patch to him.
Also added linux-pci
On Tue, Sep 25, 2018 at 2:10 PM Andy Shevchenko
wrote:
>
> On Mon, Sep 24, 2018 at 9:36 AM Suganath Prabu S
> wrote:
> >
> > * Driver uses
On Mon, Sep 24, 2018 at 9:36 AM Suganath Prabu S
wrote:
>
> * Driver uses "pci_device_is_present" to check whether
> If Hot unplugged:
> the outstanding IOs with 'DID_NO_CONNECT' before removing the drives
> attached to the HBA.
> "DID_NO_CONNECT" status and free the smid, if driver detects that
On Mon, Sep 24, 2018 at 9:36 AM Suganath Prabu S
wrote:
>
> Posting below set of patches to support PCIe Hot Plug surprise removal,
> and few defect fixes.
>
> This is NOT the normal PCIe Hot Plug support, whereby the user informs the
> OS that a hot removal is desired, the OS does an orderly
>Configuration descriptor buffer consists of Device and Unit
>descriptor configurable parameters which are parsed from vendor
>specific provisioning file and then passed via configfs node at
>runtime to provision ufs device.
Can you describe your test setup?
Will try to re-test i
Am 23.09.2018 um 20:22 schrieb Stefan Priebe - Profihost AG:
>
> Am 22.09.2018 um 23:40 schrieb Bart Van Assche:
>> On 9/18/18 11:10 PM, Stefan Priebe - Profihost AG wrote:
>>> after upgrading the aacraid driver / kernel from aacraid 50792 to
>>> aacraid 50877.
>>
>> The aacraid driver version
Am 22.09.2018 um 23:40 schrieb Bart Van Assche:
> On 9/18/18 11:10 PM, Stefan Priebe - Profihost AG wrote:
>> after upgrading the aacraid driver / kernel from aacraid 50792 to
>> aacraid 50877.
>
> The aacraid driver version was updated to 50792 in commit 0662cc968ace
> ("scsi: aacraid: Update
On 9/18/18 11:10 PM, Stefan Priebe - Profihost AG wrote:
after upgrading the aacraid driver / kernel from aacraid 50792 to
aacraid 50877.
The aacraid driver version was updated to 50792 in commit 0662cc968ace
("scsi: aacraid: Update driver version") and to 50877 in commit
1cdb74b80f93
nobody?
Greets,
Stefan
Am 19.09.2018 um 08:10 schrieb Stefan Priebe - Profihost AG:
> Hello,
>
> after upgrading the aacraid driver / kernel from aacraid 50792 to
> aacraid 50877.
>
> I get aborted comands every night.
>
> kern-20180830.gz:Aug 30 01:55:26 server1044-han kernel: [63693.009056]
On 09/20/2018 07:32 PM, wenxi...@linux.vnet.ibm.com wrote:
> +
> + list_for_each_entry(res, _cfg->used_res_q, queue) {
> + if (res->add_to_ml) {
> + bus = res->bus;
> + target = res->target;
> + lun = res->lun;
> +
On 9/21/18 5:15 AM, Hannes Reinecke wrote:
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecomment()
Signed-off-by: Hannes Reinecke
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
1 file changed,
On Fri, Sep 21, 2018 at 02:15:05PM +0200, Hannes Reinecke wrote:
> The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
> at that time, so no new commands can be submitted via srp_queuecomment()
s/srp_queuecomment/srp_queuecommand/
--
Johannes Thumshirn
Thanks for your reponse and feedback,
>> If the disk has no write cache the following errors are being logged.
>> * sd 1:0:0:0: [sdb] No Caching mode page found
>> * sd 1:0:0:0: [sdb] Assuming drive cache: write through
>>
>> Lower the severity from error to info.
>> The absence of a write cache
On Thu, Sep 20, 2018 at 4:37 PM Christoph Hellwig wrote:
>
> > +u8
> > +mpt3sas_base_pci_device_is_available(struct MPT3SAS_ADAPTER *ioc)
> > +{
> > + if (ioc->pci_error_recovery ||
> > + (!pci_device_is_present(ioc->pdev)))
> > + return 0;
> > +
> > + return 1;
>
Greg,
> Split the PI SGL across the bios in the command, so each bio's
> bio_integrity_payload contains the protection information for the data
> in the bio.
That is indeed how the bio integrity code is intended to be used. I have
queued it up. Thanks!
--
Martin K. Petersen Oracle Linux
Per,
> If the disk has no write cache the following errors are being logged.
> * sd 1:0:0:0: [sdb] No Caching mode page found
> * sd 1:0:0:0: [sdb] Assuming drive cache: write through
>
> Lower the severity from error to info.
> The absence of a write cache should not be treated as an error.
>
James,
> The driver currently uses the ndlp to get the local rport which is
> then used to get the nvme transport remoteport pointer. There can
> be cases where a stale remoteport pointer is obtained as
> synchronization isn't done through the different dereferences.
>
> Correct by using locks
On 06/11/2018 04:08 PM, James Bottomley wrote:
On Mon, 2018-06-11 at 14:59 -0700, Ted Cabeen wrote:
On 06/11/2018 02:40 PM, James Bottomley wrote:
On Mon, 2018-06-11 at 12:20 -0400, Douglas Gilbert wrote:
I have also seen Aborted Command sense when doing heavy testing
on one or more SAS disks
On Thu, Sep 20, 2018 at 08:30:29AM +, Avri Altman wrote:
> > > +
> > > + hba->dev_cmd.complete =
> > > +
> > > + /* Make sure descriptors are ready before ringing the doorbell */
> > > + wmb();
> > > + spin_lock_irqsave(hba->host->host_lock, flags);
> > > + ufshcd_send_command(hba, tag);
> >
> > +static inline struct ufs_hba *dev_to_ufs_hba(struct device *d)
> > +{
> > + struct Scsi_Host *shost = dev_to_shost(d->parent);
> > +
> > + return shost_priv(shost);
>
> This just has one caller that culd directly do:
>
> struct ufs_hba *hba =
> +u8
> +mpt3sas_base_pci_device_is_available(struct MPT3SAS_ADAPTER *ioc)
> +{
> + if (ioc->pci_error_recovery ||
> + (!pci_device_is_present(ioc->pdev)))
> + return 0;
> +
> + return 1;
> +}
This should simplify be:
bool
Hi Anil,
I love your patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Add-FC-NVMe-Target-support/20180916-090108
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
smatch warnings:
> > + lrbp->command_type = hba->ufs_version == UFSHCI_VERSION_10 ||
> > +hba->ufs_version == UFSHCI_VERSION_11 ?
> > +UTP_CMD_TYPE_DEV_MANAGE :
> > +UTP_CMD_TYPE_UFS_STORAGE;
>
> I think a good old if/self or even a switch
On Mon, Sep 17, 2018 at 07:08:55PM +0300, Avri Altman wrote:
> Do that for the currently supported UPIUs:
> query, nop out, and task management.
>
> We do not support UPIU of type scsi command yet, while
> we are using the job's request and reply pointers to hold
> the payload. We will look into
> + lrbp->command_type = hba->ufs_version == UFSHCI_VERSION_10 ||
> + hba->ufs_version == UFSHCI_VERSION_11 ?
> + UTP_CMD_TYPE_DEV_MANAGE :
> + UTP_CMD_TYPE_UFS_STORAGE;
I think a good old if/self or even a switch
This looks generally fine to me (module comments from Bart).
501 - 600 of 39577 matches
Mail list logo
